Change the meaning of "Widget::GetTopLevelWidget()" to mean the logical top level Window in the v...

views/widget/native_widget_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_views.h"
 
 #include "ui/gfx/compositor/compositor.h"
+#include "views/desktop/desktop_window_view.h"
 #include "views/view.h"
 #include "views/views_delegate.h"
 #include "views/widget/native_widget_view.h"
 #include "views/widget/root_view.h"
 
 namespace views {
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeWidgetViews, public:
 
 NativeWidgetViews::NativeWidgetViews(internal::NativeWidgetDelegate* delegate)
     : delegate_(delegate),
       view_(NULL),
       active_(false),
       minimized_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(close_widget_factory_(this)),
-      hosting_widget_(NULL) {
+      hosting_widget_(NULL),
+      ownership_(Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET),
+      delete_native_view_(true) {
 }
 
 NativeWidgetViews::~NativeWidgetViews() {
+  delegate_->OnNativeWidgetDestroying();
+  if (delete_native_view_) {
+    view_->parent()->RemoveChildView(view_);
+    // We must prevent the NativeWidgetView from attempting to delete us.
+    view_->set_delete_native_widget(false);
+    delete view_;
+  }
+  delegate_->OnNativeWidgetDestroyed();
+  if (ownership_ == Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET)
+    delete delegate_;
 }
 
 View* NativeWidgetViews::GetView() {
   return view_;
 }
 
 const View* NativeWidgetViews::GetView() const {
   return view_;
 }
 
 void NativeWidgetViews::OnActivate(bool active) {
   active_ = active;
   view_->SchedulePaint();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeWidgetViews, NativeWidget implementation:
 
 void NativeWidgetViews::InitNativeWidget(const Widget::InitParams& params) {
+  ownership_ = params.ownership;
   View* desktop_view = ViewsDelegate::views_delegate->GetDefaultParentView();
   hosting_widget_ = desktop_view->GetWidget();
   view_ = new internal::NativeWidgetView(this);
   view_->SetBoundsRect(params.bounds);
   view_->SetPaintToLayer(true);
+  // TODO(beng): This is insufficient. While this handles the case where
+  //             params.parent_widget is NULL, we need to somehow handle a case
+  //             where we are passed a specified, valid parent. We may have to
+  //             add View* Widget::GetContainerView().
   desktop_view->AddChildView(view_);
 
   // TODO(beng): handle parenting.
   // TODO(beng): SetInitParams().
 }
 
 NonClientFrameView* NativeWidgetViews::CreateNonClientFrameView() {
   return NULL;
 }
 
@@ skipping 17 matching lines @@
 }
 
 gfx::NativeView NativeWidgetViews::GetNativeView() const {
   return GetParentNativeWidget()->GetNativeView();
 }
 
 gfx::NativeWindow NativeWidgetViews::GetNativeWindow() const {
   return GetParentNativeWidget()->GetNativeWindow();
 }
 
+Widget* NativeWidgetViews::GetTopLevelWidget() {
+  if (view_->parent() == ViewsDelegate::views_delegate->GetDefaultParentView())
+    return GetWidget();
+  return view_->GetWidget()->GetTopLevelWidget();
+}
+
 const ui::Compositor* NativeWidgetViews::GetCompositor() const {
   return hosting_widget_->GetCompositor();
 }
 
 ui::Compositor* NativeWidgetViews::GetCompositor() {
   return hosting_widget_->GetCompositor();
 }
 
 void NativeWidgetViews::MarkLayerDirty() {
   view_->MarkLayerDirty();
@@ skipping 128 matching lines @@
 
 void NativeWidgetViews::Close() {
   Hide();
   if (close_widget_factory_.empty()) {
     MessageLoop::current()->PostTask(FROM_HERE,
         close_widget_factory_.NewRunnableMethod(&NativeWidgetViews::CloseNow));
   }
 }
 
 void NativeWidgetViews::CloseNow() {
-  view_->parent()->RemoveChildView(view_);
-  delete view_;
+  // TODO(beng): what about the other case??
+  if (ownership_ == Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET)
+    delete view_;
 }
 
 void NativeWidgetViews::EnableClose(bool enable) {
 }
 
 void NativeWidgetViews::Show() {
   view_->SetVisible(true);
 }
 
 void NativeWidgetViews::Hide() {
@@ skipping 123 matching lines @@
 }
 
 const internal::NativeWidgetPrivate*
     NativeWidgetViews::GetParentNativeWidget() const {
   return static_cast<const internal::NativeWidgetPrivate*>(
       view_->GetWidget()->native_widget());
 }
 
 }  // namespace views