Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 7273024: Change a label of the HTML5 multiple file chooser to "Choose One or More Files" (Closed)

Created:
9 years, 5 months ago by haraken1
Modified:
9 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Change a label of the HTML5 multiple file chooser to "Choose One or More Files". Add "default:" to the WebLocalizedString switch statement in ToMessageID(). This is needed to avoid compiler warnings about enum coverage when we add new symbols to WebLocalizedString.h. This "default:" is going to be removed when a planned WebLocalizedString.h change is merged. BUG=https://bugs.webkit.org/show_bug.cgi?id=49245 TEST=No change in behavior Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91051

Patch Set 1 #

Patch Set 2 : Add a special macro to resolve dependency between Chromium and WebKit #

Patch Set 3 : Add default: instead of a tricky macro #

Patch Set 4 : Change "Choose One or More Files" to "Choose Files" #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M webkit/glue/webkit_strings.grd View 1 2 3 1 chunk +3 lines, -0 lines 1 comment Download
M webkit/glue/webkitclient_impl.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken1
I am trying to fix WebKit bug 49245 (https://bugs.webkit.org/show_bug.cgi?id=49245). Since the WebKit patch depends on ...
9 years, 5 months ago (2011-06-28 07:17:14 UTC) #1
haraken1
I found that things are a bit complicated... This Chromium patch is depending on the ...
9 years, 5 months ago (2011-06-28 14:37:20 UTC) #2
tkent
You don't need such tricky macro. See the following changes: 1. http://src.chromium.org/viewvc/chrome?view=rev&revision=65502 2. https://trac.webkit.org/changeset/72363 3. ...
9 years, 5 months ago (2011-06-28 15:17:30 UTC) #3
haraken1
Thank you. I would follow your idea. On 2011/06/28 15:17:30, Kent Tamura wrote: > You ...
9 years, 5 months ago (2011-06-29 01:18:32 UTC) #4
tony
LGTM
9 years, 5 months ago (2011-06-29 22:27:42 UTC) #5
commit-bot: I haz the power
Change committed as 91051
9 years, 5 months ago (2011-06-29 23:46:19 UTC) #6
tkent
http://codereview.chromium.org/7273024/diff/6004/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): http://codereview.chromium.org/7273024/diff/6004/webkit/glue/webkit_strings.grd#newcode270 webkit/glue/webkit_strings.grd:270: <message name="IDS_FORM_MULTIPLE_FILES_BUTTON_LABEL" desc="title for file button used in HTML5 ...
9 years, 5 months ago (2011-06-30 00:31:52 UTC) #7
haraken1
9 years, 5 months ago (2011-06-30 00:42:04 UTC) #8
Kent: Sorry for committing this patch...
I would like to fix the description when I remove the "default:" line in the
next patch.

Powered by Google App Engine
This is Rietveld 408576698