Stop using deprecated factory API for SkDevice

skia/ext/bitmap_platform_device_linux.h

Index: skia/ext/bitmap_platform_device_linux.h
===================================================================
--- skia/ext/bitmap_platform_device_linux.h	(revision 90617)
+++ skia/ext/bitmap_platform_device_linux.h	(working copy)
@@ -44,13 +44,6 @@
 
 namespace skia {
 
-class BitmapPlatformDeviceFactory : public SkDeviceFactory {
- public:
-  virtual SkDevice* newDevice(SkCanvas* ignored, SkBitmap::Config config,
-                              int width, int height,
-                              bool isOpaque, bool isForLayer);
-};
-
 // -----------------------------------------------------------------------------
 // This is the Linux bitmap backing for Skia. We create a Cairo image surface
 // to store the backing buffer. This buffer is BGRA in memory (on little-endian
@@ -93,8 +86,8 @@
   virtual cairo_t* BeginPlatformPaint();
 
  protected:
-  // Override SkDevice.
-  virtual SkDeviceFactory* onNewDeviceFactory();
+  virtual SkDevice* onCreateCompatibleDevice(SkBitmap::Config,  int width,

[vandebo (ex-Chrome), 2011/06/28 19:07:54]

nit: extra space after Config. (multiple occurrences.)

+                                             int height, bool isOpaque, Usage);

[vandebo (ex-Chrome), 2011/06/28 19:07:54]

nit: 'Usage usage' or 'SkDevice:Usage usage' (multiple occurences.)

[vandebo (ex-Chrome), 2011/06/30 21:58:36]

Yea, the ask is Usage usage, or if you can think of a better name for it, Usage
foo.  The Google C++ style guide says "All parameters should be named, with
identical names in the declaration and implementation." 
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Decla...
 I don't see anything counter acting that in the Chrome style guide.

I agree that Usage usage is kind of silly, but scanning the header, just Usage
sticks out as something being different/wrong and Usage usage doesn't strike me
as silly until I actually read it.

 
  private:
   static BitmapPlatformDevice* Create(int width, int height, bool is_opaque,