Stop using deprecated factory API for SkDevice

skia/ext/bitmap_platform_device_linux.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SKIA_EXT_BITMAP_PLATFORM_DEVICE_LINUX_H_
 #define SKIA_EXT_BITMAP_PLATFORM_DEVICE_LINUX_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
@@ skipping 26 matching lines @@
 // typically don't do alpha blending of drawables at the user level. Composite
 // extensions aside.)
 //
 // We don't use GdkPixbuf because its byte order differs from the rest. Most
 // importantly, it differs from Cairo which, being a system library, is
 // something that we can't easily change.
 // -----------------------------------------------------------------------------
 
 namespace skia {
 
-class BitmapPlatformDeviceFactory : public SkDeviceFactory {
- public:
-  virtual SkDevice* newDevice(SkCanvas* ignored, SkBitmap::Config config,
-                              int width, int height,
-                              bool isOpaque, bool isForLayer);
-};
-
 // -----------------------------------------------------------------------------
 // This is the Linux bitmap backing for Skia. We create a Cairo image surface
 // to store the backing buffer. This buffer is BGRA in memory (on little-endian
 // machines).
 //
 // For now we are also using Cairo to paint to the Drawables so we provide an
 // accessor for getting the surface.
 //
 // This is all quite ok for test_shell. In the future we will want to use
 // shared memory between the renderer and the main process at least. In this
@@ skipping 22 matching lines @@
   virtual void MakeOpaque(int x, int y, int width, int height);
 
   // Overridden from SkDevice:
   virtual void setMatrixClip(const SkMatrix& transform, const SkRegion& region,
                              const SkClipStack&);
 
   // Overridden from PlatformDevice:
   virtual cairo_t* BeginPlatformPaint();
 
  protected:
-  // Override SkDevice.
-  virtual SkDeviceFactory* onNewDeviceFactory();
+  virtual SkDevice* onCreateCompatibleDevice(SkBitmap::Config,  int width,

[vandebo (ex-Chrome), 2011/06/28 19:07:54]

nit: extra space after Config. (multiple occurrences.)

+                                             int height, bool isOpaque, Usage);

[vandebo (ex-Chrome), 2011/06/28 19:07:54]

nit: 'Usage usage' or 'SkDevice:Usage usage' (multiple occurences.)

[vandebo (ex-Chrome), 2011/06/30 21:58:36]

Yea, the ask is Usage usage, or if you can think of a better name for it, Usage
foo.  The Google C++ style guide says "All parameters should be named, with
identical names in the declaration and implementation." 
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Decla...
 I don't see anything counter acting that in the Chrome style guide.

I agree that Usage usage is kind of silly, but scanning the header, just Usage
sticks out as something being different/wrong and Usage usage doesn't strike me
as silly until I actually read it.

 
  private:
   static BitmapPlatformDevice* Create(int width, int height, bool is_opaque,
                                       cairo_surface_t* surface);
 
   scoped_refptr<BitmapPlatformDeviceData> data_;
 
   DISALLOW_COPY_AND_ASSIGN(BitmapPlatformDevice);
 };
 
 }  // namespace skia
 
 #endif  // SKIA_EXT_BITMAP_PLATFORM_DEVICE_LINUX_H_