Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: skia/ext/bitmap_platform_device_linux.cc

Issue 7273013: Stop using deprecated factory API for SkDevice (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/bitmap_platform_device_linux.cc
===================================================================
--- skia/ext/bitmap_platform_device_linux.cc (revision 90617)
+++ skia/ext/bitmap_platform_device_linux.cc (working copy)
@@ -37,15 +37,6 @@
} // namespace
-SkDevice* BitmapPlatformDeviceFactory::newDevice(SkCanvas* ignored,
- SkBitmap::Config config,
- int width, int height,
- bool isOpaque,
- bool isForLayer) {
- SkASSERT(config == SkBitmap::kARGB_8888_Config);
- return BitmapPlatformDevice::Create(width, height, isOpaque);
-}
-
BitmapPlatformDevice::BitmapPlatformDeviceData::BitmapPlatformDeviceData(
cairo_surface_t* surface)
: surface_(surface),
@@ -136,8 +127,10 @@
BitmapPlatformDevice::~BitmapPlatformDevice() {
}
-SkDeviceFactory* BitmapPlatformDevice::onNewDeviceFactory() {
- return SkNEW(BitmapPlatformDeviceFactory);
+SkDevice* BitmapPlatformDevice::onCreateCompatibleDevice(
+ SkBitmap::Config config, int width, int height, bool isOpaque, Usage) {
vandebo (ex-Chrome) 2011/06/28 19:07:54 nit: 4 space indent. (multiple occurrences.)
+ SkASSERT(config == SkBitmap::kARGB_8888_Config);
alokp 2011/06/28 16:19:46 nit: I think we should use DCHECK in chromium code
+ return BitmapPlatformDevice::Create(width, height, isOpaque);
}
cairo_t* BitmapPlatformDevice::BeginPlatformPaint() {

Powered by Google App Engine
This is Rietveld 408576698