Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: views/controls/textfield/native_textfield_views.h

Issue 7265011: RenderText API Outline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add some placeholder functionality on Windows. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_views.h
diff --git a/views/controls/textfield/native_textfield_views.h b/views/controls/textfield/native_textfield_views.h
index d425472714c5d6c9cd4261284100f4ee624cfb92..2348d3ef5077bb21199fc535dd6eacbd82f8cbd5 100644
--- a/views/controls/textfield/native_textfield_views.h
+++ b/views/controls/textfield/native_textfield_views.h
@@ -33,6 +33,9 @@ class KeyEvent;
class MenuItemView;
class MenuModelAdapter;
+// TODO(msw): Divide responsibility with RenderText; revise API and fix impls.
+// TODO(msw): Make RenderText a member of NativeTextfieldViews?
+
// A views/skia only implementation of NativeTextfieldWrapper.
// No platform specific code is used.
// Following features are not yet supported.
@@ -241,6 +244,10 @@ class NativeTextfieldViews : public View,
// The text model.
scoped_ptr<TextfieldViewsModel> model_;
+ // TODO(msw): Make RenderText a member of NativeTextfieldViews?
+ //// The stylized text, cursor, selection, and the visual layout model.
+ //gfx::RenderText* render_text_;
+
// The reference to the border class. The object is owned by View::border_.
FocusableBorder* text_border_;

Powered by Google App Engine
This is Rietveld 408576698