Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: views/controls/textfield/textfield_views_model.h

Issue 7265011: RenderText API Outline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add some placeholder functionality on Windows. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/textfield_views_model.h
diff --git a/views/controls/textfield/textfield_views_model.h b/views/controls/textfield/textfield_views_model.h
index 297c8aeddd44af6949baeb82506f8293cb8fc56e..980496d531b5f3c34b41cbcc623ee5d2af08c078 100644
--- a/views/controls/textfield/textfield_views_model.h
+++ b/views/controls/textfield/textfield_views_model.h
@@ -51,6 +51,9 @@ enum MergeType {
typedef std::vector<internal::TextStyleRange*> TextStyleRanges;
+// TODO(msw): Divide responsibility with RenderText; revise API and fix impls.
+// TODO(msw): Make RenderText a member of TextfieldViewsModel?
xji 2011/07/01 18:29:44 Maybe make RenderText a member of TextfieldViewsMo
msw 2011/07/01 21:52:15 Yeah, I'm leaning in that direction now, thanks fo
+
// A model that represents a text content for TextfieldViews.
// It supports editing, selection and cursor manipulation.
class TextfieldViewsModel {
@@ -402,6 +405,10 @@ class TextfieldViewsModel {
// List of style ranges for composition text.
TextStyleRanges composition_style_ranges_;
+ // TODO(msw): Make RenderText a member of TextfieldViewsModel?
+ //// The stylized text, cursor, selection, and the visual layout model.
+ //gfx::RenderText* render_text_;
+
DISALLOW_COPY_AND_ASSIGN(TextfieldViewsModel);
};
« ui/gfx/render_text.cc ('K') | « views/controls/textfield/native_textfield_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698