Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7829)

Unified Diff: chrome/common/extensions/extension_l10n_util.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_message_bundle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_l10n_util.h
===================================================================
--- chrome/common/extensions/extension_l10n_util.h (revision 92173)
+++ chrome/common/extensions/extension_l10n_util.h (working copy)
@@ -12,7 +12,6 @@
#include <string>
#include <vector>
-class DictionaryValue;
class Extension;
class ExtensionMessageBundle;
class FilePath;
@@ -20,6 +19,10 @@
class ResourceDispatcherHostRequestInfo;
struct ExtensionInfo;
+namespace base {
+class DictionaryValue;
+}
+
namespace extension_l10n_util {
// Set the locale for this process to a fixed value, rather than using the
@@ -29,7 +32,7 @@
// Returns default locale in form "en-US" or "sr" or empty string if
// "default_locale" section was not defined in the manifest.json file.
-std::string GetDefaultLocaleFromManifest(const DictionaryValue& manifest,
+std::string GetDefaultLocaleFromManifest(const base::DictionaryValue& manifest,
std::string* error);
// Returns true iff the extension was localized, and the current locale
@@ -39,13 +42,13 @@
// Localize extension name, description, browser_action and other fields
// in the manifest.
bool LocalizeManifest(const ExtensionMessageBundle& messages,
- DictionaryValue* manifest,
+ base::DictionaryValue* manifest,
std::string* error);
// Load message catalogs, localize manifest and attach message bundle to the
// extension.
bool LocalizeExtension(const FilePath& extension_path,
- DictionaryValue* manifest,
+ base::DictionaryValue* manifest,
std::string* error);
// Adds locale_name to the extension if it's in chrome_locales, and
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_message_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698