Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: chrome/browser/extensions/extension_sidebar_api.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sidebar_api.h
===================================================================
--- chrome/browser/extensions/extension_sidebar_api.h (revision 92173)
+++ chrome/browser/extensions/extension_sidebar_api.h (working copy)
@@ -8,11 +8,14 @@
#include <string>
#include "chrome/browser/extensions/extension_function.h"
-class DictionaryValue;
class Profile;
class RenderViewHost;
class TabContents;
+namespace base {
+class DictionaryValue;
+}
+
namespace extension_sidebar_constants {
extern const char kActiveState[];
extern const char kHiddenState[];
@@ -38,14 +41,14 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details) = 0;
+ const base::DictionaryValue& details) = 0;
};
class CollapseSidebarFunction : public SidebarFunction {
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.collapse");
};
@@ -53,7 +56,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.expand");
};
@@ -61,7 +64,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.getState");
};
@@ -69,7 +72,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.hide");
};
@@ -77,7 +80,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.navigate");
};
@@ -85,7 +88,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.setBadgeText");
};
@@ -93,7 +96,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.setIcon");
};
@@ -101,7 +104,7 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.setTitle");
};
@@ -109,9 +112,8 @@
private:
virtual bool RunImpl(TabContents* tab,
const std::string& content_id,
- const DictionaryValue& details);
+ const base::DictionaryValue& details);
DECLARE_EXTENSION_FUNCTION_NAME("experimental.sidebar.show");
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SIDEBAR_API_H_
-
« no previous file with comments | « chrome/browser/extensions/extension_proxy_api_helpers.h ('k') | chrome/browser/extensions/extension_tabs_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698