Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4512)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_l10n_util.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_message_bundle.h » ('j') | chrome/common/extensions/extension_permission_set.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_l10n_util.h
===================================================================
--- chrome/common/extensions/extension_l10n_util.h (revision 91508)
+++ chrome/common/extensions/extension_l10n_util.h (working copy)
@@ -12,7 +12,6 @@
#include <string>
#include <vector>
-class DictionaryValue;
class Extension;
class ExtensionMessageBundle;
class FilePath;
@@ -20,6 +19,12 @@
class ResourceDispatcherHostRequestInfo;
struct ExtensionInfo;
+namespace base {
+class DictionaryValue;
+}
+
+using base::DictionaryValue;
brettw 2011/07/07 16:05:08 We shouldn't have this in header files other than
dmazzoni 2011/07/07 22:57:00 Done.
+
namespace extension_l10n_util {
// Set the locale for this process to a fixed value, rather than using the
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_message_bundle.h » ('j') | chrome/common/extensions/extension_permission_set.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698