Chromium Code Reviews Chromium Code Reviews
Issue 7256002:
Multi-Profiles: New Profile Setup UI (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/resources/new_profile.html |
| diff --git a/chrome/browser/resources/new_profile.html b/chrome/browser/resources/new_profile.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..8e3fc1b3196aa36879e34e983ab05f75c1452e76 |
| --- /dev/null |
| +++ b/chrome/browser/resources/new_profile.html |
| @@ -0,0 +1,56 @@ |
| +<!DOCTYPE HTML> |
| +<html i18n-values="dir:textdirection; |
| + customlogo:customlogo;"> |
| +<head> |
| +<meta charset="utf-8"> |
| +<title i18n-content="title"></title> |
| +<script src="chrome://resources/js/local_strings.js"></script> |
| +<script src="chrome://resources/js/cr.js"></script> |
| +<link rel="stylesheet" href="chrome://resources/css/button.css"> |
| +<link rel="stylesheet" href="new_profile.css"> |
| +</head> |
| +<body i18n-values=".style.fontFamily:fontfamily;"> |
| + |
|
James Hawkins
2011/06/30 23:02:58
Remove blank lines.
sail
2011/07/01 01:16:18
Done.
|
| +<div id="overlay" class="overlay"> |
|
James Hawkins
2011/06/30 23:02:58
ID and class name the same? Technically it's OK, b
sail
2011/07/01 01:16:18
Removed id since it's not being referenced.
|
| + <div id="new-profile-overlay" class="page"> |
| + <h3 i18n-content="summaryTitle"></h3> |
| + <p i18n-content="summaryBody"></p> |
| + <p i18n-content="summaryConclusion"></p> |
| + |
| + <div align="center"> |
| + <table> |
|
James Hawkins
2011/06/30 23:02:58
This is not tabular data; don't use a table.
sail
2011/07/01 01:16:18
Done.
|
| + <tr> <td i18n-content="profileNameLabel"> </td> </tr> |
| + <tr> <td> |
| + <form id="profile-name-form"> |
| + <input id="profile-name" type="text"/> |
| + </form> |
| + </td> </tr> |
| + <tr> <td i18n-content="profileIconLabel"> </td> </tr> |
| + <tr> <td> <div id="avatar-menu"></div> </td> </tr> |
| + </table> |
| + </div> |
| + <br/> |
|
James Hawkins
2011/06/30 23:02:58
Don't use <br>; use proper styling adjustments.
sail
2011/07/01 01:16:18
Done.
|
| + |
| + <div class="action-area"> |
| + <div class="button-strip"> |
| + <input id="cancel-button" type="button" |
| + i18n-values="value:cancelProfile" /> |
|
James Hawkins
2011/06/30 23:02:58
<input> does not have an end tag, thus remove the
sail
2011/07/01 01:16:18
Done.
|
| + <input id="create-button" type="button" |
| + i18n-values="value:createProfile" /> |
| + </div> |
| + </div> |
| + </div> <!-- page --> |
|
James Hawkins
2011/06/30 23:02:58
Remove these end comments.
sail
2011/07/01 01:16:18
Done.
|
| +</div> <!-- overlay --> |
| + |
| +<div id="footer"> |
| + <div id="footer-content"> |
| + <img id="logo-img"> |
| + </div> |
| +</div> |
| + |
| +<script src="chrome://newprofile/new_profile.js"></script> |
|
James Hawkins
2011/06/30 23:02:58
Move these scripts to the top.
sail
2011/07/01 01:16:18
Do you mean move this to the head section? This br
|
| +<script src="chrome://newprofile/strings.js"></script> |
| +<script src="chrome://resources/js/i18n_template.js"></script> |
| +<script src="chrome://resources/js/i18n_process.js"></script> |
| +</body> |
| +</html> |
