chrome/browser/resources/new_profile.html - Issue 7256002: Multi-Profiles: New Profile Setup UI

Side by Side Diff: chrome/browser/resources/new_profile.html

Issue 7256002: Multi-Profiles: New Profile Setup UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html i18n-values="dir:textdirection;

	3 customlogo:customlogo;">

	4 <head>

	5 <meta charset="utf-8">

	6 <title i18n-content="title"></title>

	7 <script src="chrome://resources/js/local_strings.js"></script>

	8 <script src="chrome://resources/js/cr.js"></script>

	9 <link rel="stylesheet" href="chrome://resources/css/button.css">

	10 <link rel="stylesheet" href="new_profile.css">

	11 </head>

	12 <body i18n-values=".style.fontFamily:fontfamily;">

	13
	James Hawkins 2011/06/30 23:02:58 Remove blank lines. Remove blank lines. sail 2011/07/01 01:16:18 Done. Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > Remove blank lines. Done.
	14 <div id="overlay" class="overlay">
	James Hawkins 2011/06/30 23:02:58 ID and class name the same? Technically it's OK, b ID and class name the same? Technically it's OK, but I'd rather you make the ID more descriptive. sail 2011/07/01 01:16:18 Removed id since it's not being referenced. Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > ID and class name the same? Technically it's OK, but I'd rather you make the ID > more descriptive. Removed id since it's not being referenced.
	15 <div id="new-profile-overlay" class="page">

	16 <h3 i18n-content="summaryTitle"></h3>

	17 <p i18n-content="summaryBody"></p>

	18 <p i18n-content="summaryConclusion"></p>

	19

	20 <div align="center">

	21 <table>
	James Hawkins 2011/06/30 23:02:58 This is not tabular data; don't use a table. This is not tabular data; don't use a table. sail 2011/07/01 01:16:18 Done. Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > This is not tabular data; don't use a table. Done.
	22 <tr> <td i18n-content="profileNameLabel"> </td> </tr>

	23 <tr> <td>

	24 <form id="profile-name-form">

	25 <input id="profile-name" type="text"/>

	26 </form>

	27 </td> </tr>

	28 <tr> <td i18n-content="profileIconLabel"> </td> </tr>

	29 <tr> <td> <div id="avatar-menu"></div> </td> </tr>

	30 </table>

	31 </div>

	32 <br/>
	James Hawkins 2011/06/30 23:02:58 Don't use <br>; use proper styling adjustments. Don't use <br>; use proper styling adjustments. sail 2011/07/01 01:16:18 Done. Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > Don't use <br>; use proper styling adjustments. Done.
	33

	34 <div class="action-area">

	35 <div class="button-strip">

	36 <input id="cancel-button" type="button"

	37 i18n-values="value:cancelProfile" />
	James Hawkins 2011/06/30 23:02:58 <input> does not have an end tag, thus remove the <input> does not have an end tag, thus remove the last forward slash. sail 2011/07/01 01:16:18 Done. Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > <input> does not have an end tag, thus remove the last forward slash. Done.
	38 <input id="create-button" type="button"

	39 i18n-values="value:createProfile" />

	40 </div>

	41 </div>

	42 </div> <!-- page -->
	James Hawkins 2011/06/30 23:02:58 Remove these end comments. Remove these end comments. sail 2011/07/01 01:16:18 Done. Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > Remove these end comments. Done.
	43 </div> <!-- overlay -->

	44

	45 <div id="footer">

	46 <div id="footer-content">

	47 <img id="logo-img">

	48 </div>

	49 </div>

	50

	51 <script src="chrome://newprofile/new_profile.js"></script>
	James Hawkins 2011/06/30 23:02:58 Move these scripts to the top. Move these scripts to the top. sail 2011/07/01 01:16:18 Do you mean move this to the head section? This br Show quoted text On 2011/06/30 23:02:58, James Hawkins wrote: > Move these scripts to the top. Do you mean move this to the head section? This breaks the string loading code. It also means that I can't set the onload function in new_profile.js.
	52 <script src="chrome://newprofile/strings.js"></script>

	53 <script src="chrome://resources/js/i18n_template.js"></script>

	54 <script src="chrome://resources/js/i18n_process.js"></script>

	55 </body>

	56 </html>

OLD	NEW