Revert 90625

Reland 90618 - Remove check for entry_. From coverity CID=8237
Check result of inflateInit Coverity CID=14712

R=fischman@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90696

[Ami GONE FROM CHROMIUM, 2011-06-27 21:54:35]

LGTM

http://codereview.chromium.org/7253017/diff/3001/remoting/base/decompressor_z...
File remoting/base/decompressor_zlib.cc (right):

http://codereview.chromium.org/7253017/diff/3001/remoting/base/decompressor_z...
remoting/base/decompressor_zlib.cc:64: NOTREACHED() << "zlib init failed";
You're being consistent with the use of NOTREACHED above, but you lose
information relative to 
DCHECK_EQ(ret, Z_OK);
which I'd use if I were you.
(DCHECK version gets you ret in the log, NOTREACHED doesn't; NOTREACHED is
#define'd as DCHECK(false), so all else should be the same, except the DCHECK
version won't do the comparison at all in NDEBUG builds).

[Greg Billock, 2011-06-27 22:03:54]

http://codereview.chromium.org/7253017/diff/3001/remoting/base/decompressor_z...
File remoting/base/decompressor_zlib.cc (right):

http://codereview.chromium.org/7253017/diff/3001/remoting/base/decompressor_z...
remoting/base/decompressor_zlib.cc:64: NOTREACHED() << "zlib init failed";
On 2011/06/27 21:54:35, Ami Fischman wrote:
> You're being consistent with the use of NOTREACHED above, but you lose
> information relative to 
> DCHECK_EQ(ret, Z_OK);
> which I'd use if I were you.
> (DCHECK version gets you ret in the log, NOTREACHED doesn't; NOTREACHED is
> #define'd as DCHECK(false), so all else should be the same, except the DCHECK
> version won't do the comparison at all in NDEBUG builds).

Makes sense. updated.

[commit-bot: I haz the power, 2011-06-27 22:08:26]

Presubmit check for 7253017-2003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/http/http_cache_transaction.cc

[Greg Billock, 2011-06-27 22:32:59]

Ricardo, could you look for net/http? (This rollback is identical to
http://codereview.chromium.org/7222027/)

[rvargas (doing something else), 2011-06-27 22:48:23]

LGTM for net

[commit-bot: I haz the power, 2011-06-28 01:46:51]

Change committed as 90696