Add checks for entry_. From coverity CID=8237

Add checks for entry_. From coverity CID=8237


Check result of inflateInit Coverity CID=14712


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90618

[Greg Billock, 2011-06-22 16:16:57]

Hi, Will, did you get the git cl upload mail?

[willchan no longer on Chromium, 2011-06-22 18:32:24]

+rvargas for HttpCache, +ajwong for remoting/

I didn't get the first mail but I got the second one.

[awong, 2011-06-22 18:38:48]

LGTM

for chromoting

[rvargas (doing something else), 2011-06-23 19:00:27]

http://codereview.chromium.org/7222027/diff/2001/net/http/http_cache_transact...
File net/http/http_cache_transaction.cc (right):

http://codereview.chromium.org/7222027/diff/2001/net/http/http_cache_transact...
net/http/http_cache_transaction.cc:1033: if (entry_ && !partial_.get() ||
partial_->IsLastRange()) {
entry_ is already considered at line 1031

http://codereview.chromium.org/7222027/diff/2001/net/http/http_cache_transact...
net/http/http_cache_transaction.cc:1516: if (entry_) {
The state machine guarantees that there should be an entry at this point.

Feel free to remove the test at line 1521.

[Greg Billock, 2011-06-23 20:13:25]

http://codereview.chromium.org/7222027/diff/2001/net/http/http_cache_transact...
File net/http/http_cache_transaction.cc (right):

http://codereview.chromium.org/7222027/diff/2001/net/http/http_cache_transact...
net/http/http_cache_transaction.cc:1033: if (entry_ && !partial_.get() ||
partial_->IsLastRange()) {
On 2011/06/23 19:00:27, rvargas wrote:
> entry_ is already considered at line 1031

Done.

http://codereview.chromium.org/7222027/diff/2001/net/http/http_cache_transact...
net/http/http_cache_transaction.cc:1516: if (entry_) {
On 2011/06/23 19:00:27, rvargas wrote:
> The state machine guarantees that there should be an entry at this point.
> 
> Feel free to remove the test at line 1521.

Done. I'll mark this intentional in coverity.

[rvargas (doing something else), 2011-06-23 22:54:49]

LGTM.

I thought coverity was complaining because it saw the second check after being
used two lines before.

Thanks.

[commit-bot: I haz the power, 2011-06-27 19:30:03]

Change committed as 90618