Support minimizing the panel into 3-pixel line on Windows. Also support bringing up/down the titl...

chrome/browser/ui/panels/panel_browser_view_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/i18n/time_formatting.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 233 matching lines @@
     if (location != Extension::EXTERNAL_POLICY_DOWNLOAD) {
       expected_panel_menu_items[3].enabled = true;
       expected_panel_menu_items[4].enabled = true;
     }
     ValidateSettingsMenuItems(frame_view->settings_menu_contents_.get(),
                               arraysize(expected_panel_menu_items),
                               expected_panel_menu_items);
 
     browser_view->panel()->Close();
   }
+
+  void TestMinimizeAndRestore() {

[jennb, 2011/06/27 23:18:02]

Could you add a comment at the top of this class explaining why all the test
logic is in this class instead of in the test?  Will save others from asking the
same question I did.

[jianli, 2011/06/29 01:28:12]

Done.

+      PanelBrowserView* browser_view = CreatePanelBrowserView("PanelTest");
+    Panel* panel = browser_view->panel_.get();
+
+    EXPECT_EQ(PanelBrowserView::FULLY_RESTORED, browser_view->expand_state());
+    int initial_height = panel->GetBounds().height();
+    int titlebar_height =
+        browser_view->GetFrameView()->NonClientTopBorderHeight();
+
+    browser_view->MinimizePanel();
+    EXPECT_EQ(PanelBrowserView::FULLY_MINIMIZED, browser_view->expand_state());
+    EXPECT_LT(panel->GetBounds().height(), titlebar_height);
+    EXPECT_GT(panel->GetBounds().height(), 0);
+
+    browser_view->RestorePanel(true);
+    EXPECT_EQ(PanelBrowserView::TITLEBAR_RESTORED,
+              browser_view->expand_state());
+    EXPECT_EQ(titlebar_height, panel->GetBounds().height());
+
+    browser_view->MinimizePanel();
+    EXPECT_EQ(PanelBrowserView::FULLY_MINIMIZED, browser_view->expand_state());
+    EXPECT_LT(panel->GetBounds().height(), titlebar_height);
+    EXPECT_GT(panel->GetBounds().height(), 0);
+
+    browser_view->RestorePanel(true);
+    EXPECT_EQ(PanelBrowserView::TITLEBAR_RESTORED,
+              browser_view->expand_state());
+    EXPECT_EQ(titlebar_height, panel->GetBounds().height());
+
+    browser_view->RestorePanel(false);
+    EXPECT_EQ(PanelBrowserView::FULLY_RESTORED, browser_view->expand_state());
+    EXPECT_EQ(initial_height, panel->GetBounds().height());
+
+    // No-op if we try to "restore" from full height to titlebar height.
+    browser_view->RestorePanel(true);
+    EXPECT_EQ(PanelBrowserView::FULLY_RESTORED, browser_view->expand_state());
+    EXPECT_EQ(initial_height, panel->GetBounds().height());
+
+    browser_view->panel()->Close();
+  }
 };
 
 // Panel is not supported for Linux view yet.
 #if !defined(OS_LINUX) || !defined(TOOLKIT_VIEWS)
 IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, CreatePanel) {
   PanelBrowserView* browser_view = CreatePanelBrowserView("PanelTest");
   PanelBrowserFrameView* frame_view = browser_view->GetFrameView();
 
   // The bounds animation should not be triggered when the panel is up for the
   // first time.
@@ skipping 278 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, CreateSettingsMenu) {
   TestCreateSettingsMenuForExtension(
       FILE_PATH_LITERAL("extension1"), Extension::EXTERNAL_POLICY_DOWNLOAD,
       "", "");
   TestCreateSettingsMenuForExtension(
       FILE_PATH_LITERAL("extension2"), Extension::INVALID,
       "http://home", "options.html");
 }
+
+IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, MinimizeAndRestore) {
+  TestMinimizeAndRestore();
+}
 #endif