Support for testing by providing access to DownloadsList.

Support for testing by providing access to DownloadsList.

BUG=NONE
TEST=NONE

[achuithb, 2011-06-22 22:50:50]

http://codereview.chromium.org/7241007/diff/1/chrome/browser/ui/webui/active_...
File chrome/browser/ui/webui/active_downloads_ui.cc (right):

http://codereview.chromium.org/7241007/diff/1/chrome/browser/ui/webui/active_...
chrome/browser/ui/webui/active_downloads_ui.cc:442:
static_cast<ActiveDownloadsHandler*>(handlers_[1]);
I don't like this either :/

[xiyuan, 2011-06-22 23:01:03]

http://codereview.chromium.org/7241007/diff/1/chrome/browser/ui/webui/active_...
File chrome/browser/ui/webui/active_downloads_ui.cc (right):

http://codereview.chromium.org/7241007/diff/1/chrome/browser/ui/webui/active_...
chrome/browser/ui/webui/active_downloads_ui.cc:442:
static_cast<ActiveDownloadsHandler*>(handlers_[1]);
On 2011/06/22 22:50:50, achuith.bhandarkar wrote:
> I don't like this either :/

Me neither. What is the other handler here? How could we be sure that
ActiveDownloadsHandler would always be at index 1? 

Maybe we should just keep a reference to it as a member var?

[achuithb, 2011-06-23 02:56:38]

http://codereview.chromium.org/7241007/diff/1/chrome/browser/ui/webui/active_...
File chrome/browser/ui/webui/active_downloads_ui.cc (right):

http://codereview.chromium.org/7241007/diff/1/chrome/browser/ui/webui/active_...
chrome/browser/ui/webui/active_downloads_ui.cc:442:
static_cast<ActiveDownloadsHandler*>(handlers_[1]);
The other handler is the GenericHandler that all WebUI have (it gets added in
the WebUI constructor). Anyway, this stuff is pretty fragile since somebody
could add another handler and mess this up, as you noted.

I didn't keep a member var reference because ActiveDownloadsHandler was in an
anonymous namespace and so I couldn't forward declare it in the header file. I
was too lazy to move the class definition of ActiveDownloadsHandler out of the
anonymous namespace, but I've done it now. PTAL.

http://codereview.chromium.org/7241007/diff/2002/chrome/browser/ui/webui/acti...
File chrome/browser/ui/webui/active_downloads_ui.cc (left):

http://codereview.chromium.org/7241007/diff/2002/chrome/browser/ui/webui/acti...
chrome/browser/ui/webui/active_downloads_ui.cc:86: // The handler for Javascript
messages related to the "active_downloads" view.
This code just moved out of the anonymous namespace. No code change.

[xiyuan, 2011-06-23 16:04:13]

LGTM

[commit-bot: I haz the power, 2011-06-23 18:09:01]

Change committed as 90232