Support for testing by providing access to DownloadsList.

chrome/browser/ui/webui/active_downloads_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/active_downloads_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 96 matching lines @@
   virtual void ModelChanged();
 
   // WebUI Callbacks.
   void HandleGetDownloads(const ListValue* args);
   void HandlePauseToggleDownload(const ListValue* args);
   void HandleCancelDownload(const ListValue* args);
   void HandleAllowDownload(const ListValue* args);
   void OpenNewFullWindow(const ListValue* args);
   void PlayMediaFile(const ListValue* args);
 
+  // For testing.
+  typedef std::vector<DownloadItem*> DownloadList;
+  const DownloadList& downloads() const { return downloads_; }
+
  private:
   // Downloads helpers.
   DownloadItem* GetDownloadById(const ListValue* args);
   void UpdateDownloadList();
   void SendDownloads();
   void AddDownload(DownloadItem* item);
   bool SelectTab(const GURL& url);
 
   Profile* profile_;
   TabContents* tab_contents_;
   DownloadManager* download_manager_;
 
-  typedef std::vector<DownloadItem*> DownloadList;
   DownloadList active_downloads_;
   DownloadList downloads_;
 
   DISALLOW_COPY_AND_ASSIGN(ActiveDownloadsHandler);
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // ActiveDownloadsUIHTMLSource
 //
@@ skipping 286 matching lines @@
 
       if (url.SchemeIs(chrome::kChromeUIScheme) &&
           url.host() == chrome::kChromeUIActiveDownloadsHost) {
         return (*it);
       }
     }
   }
   return NULL;
 }
 
+const ActiveDownloadsUI::DownloadList& ActiveDownloadsUI::GetDownloads() const {
+  DCHECK_EQ(handlers_.size(), size_t(2));
+  ActiveDownloadsHandler* handler =
+      static_cast<ActiveDownloadsHandler*>(handlers_[1]);

[achuithb, 2011/06/22 22:50:50]

I don't like this either :/

[xiyuan, 2011/06/22 23:01:03]

Me neither. What is the other handler here? How could we be sure that
ActiveDownloadsHandler would always be at index 1? 

Maybe we should just keep a reference to it as a member var?

[achuithb, 2011/06/23 02:56:38]

The other handler is the GenericHandler that all WebUI have (it gets added in
the WebUI constructor). Anyway, this stuff is pretty fragile since somebody
could add another handler and mess this up, as you noted.

I didn't keep a member var reference because ActiveDownloadsHandler was in an
anonymous namespace and so I couldn't forward declare it in the header file. I
was too lazy to move the class definition of ActiveDownloadsHandler out of the
anonymous namespace, but I've done it now. PTAL.

+  return handler->downloads();
+}