Issue 7240029: UI 'accurateness' control

Issue 7240029: UI 'accurateness' control (Closed)

Created:
9 years, 6 months ago by Peter Rybin

Modified:
9 years, 6 months ago

Reviewers:
apavlov

CC:
chromedevtools-dev_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

Description

UI 'accurateness' control Committed: http://code.google.com/p/chromedevtools/source/detail?r=658

Patch Set 2 : fcr #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -0 lines)			Patch
A	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java	View	1	1 chunk	+247 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/Messages.java	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apavlov

LGTM http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java File plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java (right): http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java#newcode29 plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java:29: AccuratenessControl(Composite composite, String[] pathSegments, int initialAccuratenessValue) { You ...

9 years, 6 months ago (2011-06-27 09:03:40 UTC) #2

Peter Rybin

9 years, 6 months ago (2011-06-27 16:39:07 UTC) #3

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/s...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/s...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java:29:
AccuratenessControl(Composite composite, String[] pathSegments, int
initialAccuratenessValue) {
On 2011/06/27 09:03:43, apavlov wrote:
> You might want to use the Eclipse IPath/Path types instead

I thought about this, but I ruled out there's no need to add an extra dependency
for no profit.

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/s...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/s...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties:1:
AccuratenessControl_LESS_BUTTON0=< Less
On 2011/06/27 09:03:43, apavlov wrote:
> Please rename the constant

OMG, didn't see this. Thanks
Done

Expand Messages | Collapse Messages