net: Add NET_API for some linux-only files

base/base_api.h

Index: base/base_api.h
===================================================================
--- base/base_api.h	(revision 90330)
+++ base/base_api.h	(working copy)
@@ -8,15 +8,18 @@
 
 #if defined(BASE_DLL)
 #if defined(WIN32)
+
 #if defined(BASE_IMPLEMENTATION)
 #define BASE_API __declspec(dllexport)
 #else
 #define BASE_API __declspec(dllimport)
 #endif  // defined(BASE_IMPLEMENTATION)
-#else
+
+#else  // defined(WIN32)
 #define BASE_API __attribute__((visibility("default")))
-#endif  // defined(WIN32)
-#else
+#endif
+

[wtc, 2011/06/24 23:18:48]

These blank lines don't work for me either, so please
remove them.  Sorry about that.

Perhaps only the use of indentation will help, but we
don't indent ifdefs in the Chromium code base.

The comments you added do help though.  Thanks.

[rvargas (doing something else), 2011/06/24 23:27:58]

Actually the lines help me (although they look weird here with green lines).

I'd prefer to keep them unless you guys think it is better without them.

On 2011/06/24 23:18:48, wtc wrote:

[wtc, 2011/06/24 23:44:19]

OK! :-)

I'm afraid that only indentation would work for me:

#if defined(BASE_DLL)
#  if defined(WIN32)
#    if defined(BASE_IMPLEMENTATION)
#    define BASE_API __declspec(dllexport)
#    else
#    define BASE_API __declspec(dllimport)
#    endif  // defined(BASE_IMPLEMENTATION)
#  else  // defined(WIN32)
#    define BASE_API __attribute__((visibility("default")))
#  endif
#else  // defined(BASE_DLL)
#  define BASE_API
#endif

[rvargas (doing something else), 2011/06/25 01:16:45]

yes, indenting will be the most clear, but we don't do that... and it has the
disadvantage of failing on a search for "#define foo"

I need an approval for base anyway... so, Brett, wdyt?

[brettw, 2011/06/30 21:17:33]

We don't normally do the indenting. I think in this case with your blank lines
it's good enough. If it was much more complicated we'd have to do some kind of
indenting or it would be totally unreadable.

+#else  // defined(BASE_DLL)
 #define BASE_API
 #endif