base/base_api.h - Issue 7240021: net: Add NET_API for some linux-only files

Side by Side Diff: base/base_api.h

Issue 7240021: net: Add NET_API for some linux-only files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_BASE_API_H_	5 #ifndef BASE_BASE_API_H_

6 #define BASE_BASE_API_H_	6 #define BASE_BASE_API_H_

7 #pragma once	7 #pragma once

8	8

9 #if defined(BASE_DLL)	9 #if defined(BASE_DLL)

10 #if defined(WIN32)	10 #if defined(WIN32)

	11

11 #if defined(BASE_IMPLEMENTATION)	12 #if defined(BASE_IMPLEMENTATION)

12 #define BASE_API __declspec(dllexport)	13 #define BASE_API __declspec(dllexport)

13 #else	14 #else

14 #define BASE_API __declspec(dllimport)	15 #define BASE_API __declspec(dllimport)

15 #endif // defined(BASE_IMPLEMENTATION)	16 #endif // defined(BASE_IMPLEMENTATION)

16 #else	17

	18 #else // defined(WIN32)

17 #define BASE_API __attribute__((visibility("default")))	19 #define BASE_API __attribute__((visibility("default")))

18 #endif // defined(WIN32)	20 #endif

19 #else	21
	wtc 2011/06/24 23:18:48 These blank lines don't work for me either, so ple These blank lines don't work for me either, so please remove them. Sorry about that. Perhaps only the use of indentation will help, but we don't indent ifdefs in the Chromium code base. The comments you added do help though. Thanks. rvargas (doing something else) 2011/06/24 23:27:58 Actually the lines help me (although they look wei Actually the lines help me (although they look weird here with green lines). I'd prefer to keep them unless you guys think it is better without them. On 2011/06/24 23:18:48, wtc wrote: Show quoted text > These blank lines don't work for me either, so please > remove them. Sorry about that. > > Perhaps only the use of indentation will help, but we > don't indent ifdefs in the Chromium code base. > > The comments you added do help though. Thanks. wtc 2011/06/24 23:44:19 OK! :-) I'm afraid that only indentation would wo Show quoted text On 2011/06/24 23:27:58, rvargas wrote: > Actually the lines help me (although they look weird here with green lines). > > I'd prefer to keep them unless you guys think it is better without them. OK! :-) I'm afraid that only indentation would work for me: #if defined(BASE_DLL) # if defined(WIN32) # if defined(BASE_IMPLEMENTATION) # define BASE_API __declspec(dllexport) # else # define BASE_API __declspec(dllimport) # endif // defined(BASE_IMPLEMENTATION) # else // defined(WIN32) # define BASE_API __attribute__((visibility("default"))) # endif #else // defined(BASE_DLL) # define BASE_API #endif rvargas (doing something else) 2011/06/25 01:16:45 yes, indenting will be the most clear, but we don' Show quoted text On 2011/06/24 23:44:19, wtc wrote: > On 2011/06/24 23:27:58, rvargas wrote: > > Actually the lines help me (although they look weird here with green lines). > > > > I'd prefer to keep them unless you guys think it is better without them. > > OK! :-) > > I'm afraid that only indentation would work for me: > > #if defined(BASE_DLL) > # if defined(WIN32) > # if defined(BASE_IMPLEMENTATION) > # define BASE_API __declspec(dllexport) > # else > # define BASE_API __declspec(dllimport) > # endif // defined(BASE_IMPLEMENTATION) > # else // defined(WIN32) > # define BASE_API __attribute__((visibility("default"))) > # endif > #else // defined(BASE_DLL) > # define BASE_API > #endif yes, indenting will be the most clear, but we don't do that... and it has the disadvantage of failing on a search for "#define foo" I need an approval for base anyway... so, Brett, wdyt? brettw 2011/06/30 21:17:33 We don't normally do the indenting. I think in thi We don't normally do the indenting. I think in this case with your blank lines it's good enough. If it was much more complicated we'd have to do some kind of indenting or it would be totally unreadable.
	22 #else // defined(BASE_DLL)

20 #define BASE_API	23 #define BASE_API

21 #endif	24 #endif

22	25

23 #endif // BASE_BASE_API_H_	26 #endif // BASE_BASE_API_H_

OLD	NEW

« no previous file with comments | « no previous file | crypto/crypto_api.h » ('j') | no next file with comments »