Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2639)

Unified Diff: base/string_util.cc

Issue 7238018: Upstream android string implementation etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed the comments Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/string_number_conversions.cc ('k') | base/sys_string_conversions_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/string_util.cc
diff --git a/base/string_util.cc b/base/string_util.cc
index 31c5e1ac626fd795bb6a21946d97b4a0c34dfa0f..4757a85a0e6df0c79a70682005473ac9b6206463 100644
--- a/base/string_util.cc
+++ b/base/string_util.cc
@@ -513,6 +513,8 @@ bool LowerCaseEqualsASCII(string16::const_iterator a_begin,
}
#endif
+// TODO(port): Resolve wchar_t/iterator issues that require OS_ANDROID here.
+#if !defined(OS_ANDROID)
bool LowerCaseEqualsASCII(const char* a_begin,
const char* a_end,
const char* b) {
@@ -533,6 +535,8 @@ bool LowerCaseEqualsASCII(const char16* a_begin,
}
#endif
+#endif // !defined(OS_ANDROID)
+
bool EqualsASCII(const string16& a, const base::StringPiece& b) {
if (a.length() != b.length())
return false;
« no previous file with comments | « base/string_number_conversions.cc ('k') | base/sys_string_conversions_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698