base/sys_string_conversions_linux.cc - Issue 7238018: Upstream android string implementation etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/sys_string_conversions_linux.cc

Issue 7238018: Upstream android string implementation etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed the comments Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/sys_string_conversions_linux.cc

diff --git a/base/sys_string_conversions_linux.cc b/base/sys_string_conversions_linux.cc

index 6a6eac940ce1cccf07ae6eb5a9641daa8e4765ae..2dc6b6f67e8ce3b00bc9140aa004dede2fd324d7 100644

--- a/base/sys_string_conversions_linux.cc

+++ b/base/sys_string_conversions_linux.cc

@@ -24,7 +24,9 @@ std::wstring SysUTF8ToWide(const StringPiece& utf8) {

return out;

}

-#if defined(OS_CHROMEOS)

+#if defined(OS_CHROMEOS) || defined(OS_ANDROID)

+// TODO(port): Consider reverting the OS_ANDROID when we have wcrtomb()

+// support and a better understanding of what calls these routines.

// ChromeOS always runs in UTF-8 locale.

std::string SysWideToNativeMB(const std::wstring& wide) {

« no previous file with comments | « base/string_util.cc ('k') | build/build_config.h » ('j') | no next file with comments »