sql::MetaTable.next_download_id, DownloadManager::GetNextId()

content/browser/resource_context.h

Index: content/browser/resource_context.h
diff --git a/content/browser/resource_context.h b/content/browser/resource_context.h
index f2ac4c56ad88c3204cac3cd8074fb540951a5d24..1798d4ce10469d0334df23793ce4153d3020be94 100644
--- a/content/browser/resource_context.h
+++ b/content/browser/resource_context.h
@@ -10,6 +10,7 @@
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
+#include "content/browser/download/download_manager.h"
 
 class ChromeAppCacheService;
 class ChromeBlobStorageContext;
@@ -75,6 +76,10 @@ class ResourceContext {
   MediaObserver* media_observer() const;
   void set_media_observer(MediaObserver* media_observer);
 
+  const DownloadManager::GetNextIdThunkType& next_download_id_thunk() const;

[jam, 2011/08/23 17:54:19]

it seems odd to add a thunk to ResourceContext. it feels very C-ish to add a
function pointer there. can we have an interface instead?

willchan (who wrote ResourceContext): I realize you already looked at this, but
I'm curious wdyt?

[benjhayden, 2011/08/24 14:33:00]

Yes, we are planning on promoting the thunk to a first-class, um, class in my
next CL. TODone.

[jam, 2011/08/24 16:35:36]

I'm curious, why check in the thunk code if you're planning on changing it in
the next cl? i.e. why not just add a class now?

[benjhayden, 2011/08/24 17:22:36]

Initializing the DownloadIdFactory will be a very different story than
initializing this thunk, and implementing that story in this CL would make it
larger than I can handle. I'll probably pass the DownloadIdFactory around as a
pointer instead of a const ref, so I'll need to change this file then anyway.

+  void set_next_download_id_thunk(
+      const DownloadManager::GetNextIdThunkType& thunk);
+
   // =======================================================================
   // TODO(willchan): These don't belong in content/. Remove them eventually.
 
@@ -100,6 +105,7 @@ class ResourceContext {
   quota::QuotaManager* quota_manager_;
   HostZoomMap* host_zoom_map_;
   MediaObserver* media_observer_;
+  DownloadManager::GetNextIdThunkType next_download_id_thunk_;
 
   // Externally-defined data accessible by key.
   typedef std::map<const void*, void*> UserDataMap;