sql::MetaTable.next_download_id, DownloadManager::GetNextId()

content/browser/resource_context.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RESOURCE_CONTEXT_H_
 #define CONTENT_BROWSER_RESOURCE_CONTEXT_H_
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
+#include "content/browser/download/download_manager.h"
 
 class ChromeAppCacheService;
 class ChromeBlobStorageContext;
 class ExtensionInfoMap;
 class HostZoomMap;
 class MediaObserver;
 namespace fileapi {
 class FileSystemContext;
 }  // namespace fileapi
 namespace net {
@@ skipping 45 matching lines @@
 
   quota::QuotaManager* quota_manager() const;
   void set_quota_manager(quota::QuotaManager* quota_manager);
 
   HostZoomMap* host_zoom_map() const;
   void set_host_zoom_map(HostZoomMap* host_zoom_map);
 
   MediaObserver* media_observer() const;
   void set_media_observer(MediaObserver* media_observer);
 
+  const DownloadManager::GetNextIdThunkType& next_download_id_thunk() const;

[jam, 2011/08/23 17:54:19]

it seems odd to add a thunk to ResourceContext. it feels very C-ish to add a
function pointer there. can we have an interface instead?

willchan (who wrote ResourceContext): I realize you already looked at this, but
I'm curious wdyt?

[benjhayden, 2011/08/24 14:33:00]

Yes, we are planning on promoting the thunk to a first-class, um, class in my
next CL. TODone.

[jam, 2011/08/24 16:35:36]

I'm curious, why check in the thunk code if you're planning on changing it in
the next cl? i.e. why not just add a class now?

[benjhayden, 2011/08/24 17:22:36]

Initializing the DownloadIdFactory will be a very different story than
initializing this thunk, and implementing that story in this CL would make it
larger than I can handle. I'll probably pass the DownloadIdFactory around as a
pointer instead of a const ref, so I'll need to change this file then anyway.

+  void set_next_download_id_thunk(
+      const DownloadManager::GetNextIdThunkType& thunk);
+
   // =======================================================================
   // TODO(willchan): These don't belong in content/. Remove them eventually.
 
   // TODO(cbentzel): Kill this one.
   const base::Callback<prerender::PrerenderManager*(void)>&
       prerender_manager_getter() const;
   void set_prerender_manager_getter(
       const base::Callback<prerender::PrerenderManager*(void)>&
           prerender_manager_getter);
 
  protected:
   ResourceContext();
 
  private:
   virtual void EnsureInitialized() const = 0;
 
   net::HostResolver* host_resolver_;
   net::URLRequestContext* request_context_;
   ChromeAppCacheService* appcache_service_;
   webkit_database::DatabaseTracker* database_tracker_;
   fileapi::FileSystemContext* file_system_context_;
   ChromeBlobStorageContext* blob_storage_context_;
   quota::QuotaManager* quota_manager_;
   HostZoomMap* host_zoom_map_;
   MediaObserver* media_observer_;
+  DownloadManager::GetNextIdThunkType next_download_id_thunk_;
 
   // Externally-defined data accessible by key.
   typedef std::map<const void*, void*> UserDataMap;
   UserDataMap user_data_;
 
 
   // =======================================================================
   // TODO(willchan): These don't belong in content/. Remove them eventually.
 
   base::Callback<prerender::PrerenderManager*(void)> prerender_manager_getter_;
 
   DISALLOW_COPY_AND_ASSIGN(ResourceContext);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RESOURCE_CONTEXT_H_