Added last_modified field to TemplateURL and database. Updated unit tests, including refactoring ...

base/mock_time_provider.h

Index: base/mock_time_provider.h
===================================================================
--- base/mock_time_provider.h	(revision 0)
+++ base/mock_time_provider.h	(revision 0)
@@ -0,0 +1,25 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "testing/gmock/include/gmock/gmock.h"
+
+#include "base/time.h"

[scherkus (not reviewing), 2011/06/22 22:12:51]

needs a header guard

[SteveT, 2011/06/23 21:15:55]

Oops. Done.

+
+namespace base {
+
+class MockTimeProvider {

[scherkus (not reviewing), 2011/06/22 22:12:51]

class could also use some usage notes

I do have to say this class is so tiny I wonder whether it's worth having in
src/base as opposed to just duplicating the code for clock_unittests, etc...

[brettw, 2011/06/22 22:52:41]

I don't understand how this works at all. If it's in source base, you should
assume people don't have a lot of experience with mock. Also, if we do put it in
base, it should be in base/test.

I'll wait for the documentation to comment about where I think it should go,
since I don't really understand how it works now.

[SteveT, 2011/06/23 21:15:55]

Added a description and some usage examples.

I agree with you that the class is tiny, but I would rather see it put in the
correct, common place rather than fully duplicating it every time we need to
mock out Time::Now.

[SteveT, 2011/06/23 21:15:55]

I've moved this to base/test and added it to the test_support_base target... for
now. Andrew and I were expecting opposition to factoring this out of media and
into base, so please let us know where you think it belongs. I would rather
avoid duplicating code, but since this class is small, we could just keep it in
the 2 locations where it's being used if you're really opposed to adding more to
base/.

I've added a description with a usage example to the file.

+ public:
+  MockTimeProvider();
+  ~MockTimeProvider();
+
+  MOCK_METHOD0(Now, Time());
+
+  static Time StaticNow();
+
+ private:
+  static MockTimeProvider* instance_;
+  DISALLOW_COPY_AND_ASSIGN(MockTimeProvider);
+};
+
+}  // namespace
Property changes on: base\mock_time_provider.h
___________________________________________________________________
Added: svn:eol-style
   + LF