Issue 7232019: removed support for 80bit FP type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7232019: removed support for 80bit FP type (Closed)

Created:
9 years, 6 months ago by robertm

Modified:
9 years, 5 months ago

Reviewers:
jvoung - send to chromium..., (google.com) Derek Schuff

Visibility:
Public.

Description

pnacl does not support the x86 specific 80bit FP type so we do not need to bloat libgcc with it. Also removed support functions for 128bit ints. Those were guarded by "#if __x86_64" and resulted in empty object files/bitcode file.

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -16 lines)			Patch
	M	compiler-rt/lib/Makefile-pnacl	View	1 2	1 chunk	+40 lines, -16 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jvoung - send to chromium...

Would it be useful to keep a list of these omitted files in a comment ...

9 years, 6 months ago (2011-06-22 20:37:11 UTC) #2

robertm

Added a comment for that - it still does not cover all the functions but ...

9 years, 6 months ago (2011-06-22 21:11:29 UTC) #3

jvoung - send to chromium...

9 years, 6 months ago (2011-06-22 21:50:54 UTC) #4

LGTM, one more suggestion

http://codereview.chromium.org/7232019/diff/6001/compiler-rt/lib/Makefile-pnacl
File compiler-rt/lib/Makefile-pnacl (right):

http://codereview.chromium.org/7232019/diff/6001/compiler-rt/lib/Makefile-pna...
compiler-rt/lib/Makefile-pnacl:35: # powitf2.c
powitf2 appears to be in the 80 bit float category (just noticed it didn't have
a "ti" in name)

Expand Messages | Collapse Messages