Modify TemplateURLRef to remove unknown URL parameters, but only when it represents a prepopulate...

Modify TemplateURLRef to remove unknown URL parameters, but only when it represents a prepopulated URL.

Also removing a friend function ParseParameterReallyUnknown which was accidentally added in r90764.

TEST=Ensure all TemplateURLTest unit tests succeed.
BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90845

[SteveT, 2011-06-28 20:11:55]

Here are the changes we discussed by email. PTAL.

[sky, 2011-06-28 21:02:26]

LGTM

http://codereview.chromium.org/7230053/diff/4002/chrome/browser/search_engine...
File chrome/browser/search_engines/template_url.cc (right):

http://codereview.chromium.org/7230053/diff/4002/chrome/browser/search_engine...
chrome/browser/search_engines/template_url.cc:694: if (id > 0)
Convert these to SetTemplateURLRefsPrepopulate(id > 0);

http://codereview.chromium.org/7230053/diff/4002/chrome/browser/search_engine...
File chrome/browser/search_engines/template_url_unittest.cc (right):

http://codereview.chromium.org/7230053/diff/4002/chrome/browser/search_engine...
chrome/browser/search_engines/template_url_unittest.cc:154:
TEST_F(TemplateURLTest, SetPrepopulatedAndParse) {
Add a description of what this is testing.

[commit-bot: I haz the power, 2011-06-28 22:15:48]

Change committed as 90845