Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 723001: add keyboard driver in st1.5 (Closed)

Created:
10 years, 9 months ago by Horace
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

add keyboard driver in st1.5 BUG=NONE TEST=Built and ran on st1.5 Signed-off-by: Horace Fu <horace.fu@quantatw.com>;

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update the keyboard driver #

Total comments: 2

Patch Set 3 : Update #

Total comments: 9

Patch Set 4 : Correct format error #

Total comments: 1

Patch Set 5 : error correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -0 lines) Patch
M drivers/input/keyboard/Kconfig View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M drivers/input/keyboard/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A drivers/input/keyboard/qci_kbd.c View 1 2 3 4 1 chunk +549 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nleeder
http://codereview.chromium.org/723001/diff/1/4 File drivers/input/keyboard/qci_kbd.c (right): http://codereview.chromium.org/723001/diff/1/4#newcode62 drivers/input/keyboard/qci_kbd.c:62: #define KEYBOARD_INT_GPIO 37 GPIO number should be passed in ...
10 years, 9 months ago (2010-03-09 21:28:48 UTC) #1
Horace
On 2010/03/09 21:28:48, nleeder wrote: Please help to review once again, thanks!
10 years, 9 months ago (2010-03-11 12:47:02 UTC) #2
nleeder
Similar comments to the trackpad driver re signed-off-by line etc. Thanks! http://codereview.chromium.org/723001/diff/4001/5001 File arch/arm/mach-msm/board-qsd8x50.c (right): ...
10 years, 9 months ago (2010-03-11 23:13:38 UTC) #3
Horace
On 2010/03/11 23:13:38, nleeder wrote: Got it, and will inform qualcomm to help to do ...
10 years, 9 months ago (2010-03-12 05:58:18 UTC) #4
nleeder
lgtm
10 years, 9 months ago (2010-03-12 21:11:06 UTC) #5
nleeder
Please also run the patch through scripts/checkpatch.pl and fix any errors. Also add user msb ...
10 years, 9 months ago (2010-03-17 18:50:30 UTC) #6
nleeder
+msb Mandeep, could you review this too? Thanks.
10 years, 9 months ago (2010-03-17 19:06:58 UTC) #7
Mandeep Singh Baines
Please run scripts/checkpatch.pl on this code. I see a lot of errors. Please sign-off on ...
10 years, 9 months ago (2010-03-18 22:05:55 UTC) #8
nleeder
Patch updated by Horace.
10 years, 9 months ago (2010-03-23 22:09:55 UTC) #9
Mandeep Singh Baines
Code looks great! Just once last nit before committing. LGTM after fixing keycode array and ...
10 years, 9 months ago (2010-03-23 22:48:04 UTC) #10
Horace
Update on2_keycode array! Please help to review again, thanks!
10 years, 9 months ago (2010-03-25 09:01:42 UTC) #11
nleeder
Is this done now - can it be committed? Thanks.
10 years, 9 months ago (2010-03-29 17:32:35 UTC) #12
Mandeep Singh Baines
10 years, 9 months ago (2010-03-29 22:26:01 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698