Issue 7227009: Add chromium_code: 1 to surface.gyp and gl.gyp to pick up -Werror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7227009: Add chromium_code: 1 to surface.gyp and gl.gyp to pick up -Werror. (Closed)

Created:
9 years, 5 months ago by Nico

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, Ben Goodger (Google), sky

CC:
chromium-reviews, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add chromium_code: 1 to surface.gyp and gl.gyp to pick up -Werror. It looks like this was dropped accidentally in http://codereview.chromium.org/6718027 (surface.gyp) and http://codereview.chromium.org/6722026 (gl.gyp) Remove now-redudant code that's implied by chromium_code: 1. Fix the warnings that have crept in since chromium_code: 1 was removed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91598 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91813

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -60 lines)			Patch
M	ui/gfx/gl/gl.gyp	View		2 chunks	+4 lines, -28 lines	0 comments	Download
M	ui/gfx/gl/gl_bindings_skia_in_process.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/gfx/gl/gl_context_glx.cc	View	1 2	2 chunks	+3 lines, -5 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_cgl.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/gl/gl_surface_glx.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/surface/surface.gyp	View		1 chunk	+4 lines, -24 lines	0 comments	Download

Total messages: 4 (0 generated)

Change committed as 91813