remoting/base/decompressor_zlib.cc - Issue 7222027: Add checks for entry_. From coverity CID=8237

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/base/decompressor_zlib.cc

Issue 7222027: Add checks for entry_. From coverity CID=8237 (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add null and return checks Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/base/decompressor_zlib.h"	5 #include "remoting/base/decompressor_zlib.h"

6	6

7 #if defined(USE_SYSTEM_ZLIB)	7 #if defined(USE_SYSTEM_ZLIB)

8 #include <zlib.h>	8 #include <zlib.h>

9 #else	9 #else

10 #include "third_party/zlib/zlib.h"	10 #include "third_party/zlib/zlib.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 }	52 }

53	53

54 void DecompressorZlib::InitStream() {	54 void DecompressorZlib::InitStream() {

55 stream_.reset(new z_stream());	55 stream_.reset(new z_stream());

56	56

57 stream_->next_in = Z_NULL;	57 stream_->next_in = Z_NULL;

58 stream_->zalloc = Z_NULL;	58 stream_->zalloc = Z_NULL;

59 stream_->zfree = Z_NULL;	59 stream_->zfree = Z_NULL;

60 stream_->opaque = Z_NULL;	60 stream_->opaque = Z_NULL;

61	61

62 inflateInit(stream_.get());	62 DCHECK(inflateInit(stream_.get()) == Z_OK);

63 }	63 }

64	64

65 } // namespace remoting	65 } // namespace remoting

OLD	NEW