Coverity fixes CID=15870,13529 Check pointer before assign, resource leak.

base/platform_file_posix.cc

Index: base/platform_file_posix.cc
diff --git a/base/platform_file_posix.cc b/base/platform_file_posix.cc
index 26c52d4682fe3e9451f4f4a24b08ce45f226752d..aaf75aca9c2331ab32f53206bb15136b664f9189 100644
--- a/base/platform_file_posix.cc
+++ b/base/platform_file_posix.cc
@@ -55,7 +55,9 @@ PlatformFile CreatePlatformFile(const FilePath& name, int flags,
       !(flags & PLATFORM_FILE_OPEN_ALWAYS)) {
     NOTREACHED();
     errno = EOPNOTSUPP;
-    *error_code = error_code ? PLATFORM_FILE_ERROR_FAILED : PLATFORM_FILE_OK;
+    if (error_code)
+      *error_code = *error_code ? PLATFORM_FILE_ERROR_FAILED :

[rvargas (doing something else), 2011/06/23 03:43:53]

I have no idea why this code was changed from what it was (r79058)... it looks
like an unintentional change.

This code should not be returning PLATFORM_FILE_OK when it fails on an
unreachable path. If this breaks something, the caller should be fixed.

[Greg Billock, 2011/06/23 16:58:32]

Yeah, I think the previous version was right. I'll copy jorlow on this change.

+          PLATFORM_FILE_OK;
     return kInvalidPlatformFileValue;
   }