Coverity fixes CID=15870,13529 Check pointer before assign, resource leak.

base/platform_file_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/platform_file.h"
 
 #include <fcntl.h>
 #include <errno.h>
 #include <sys/stat.h>
 #include <unistd.h>
@@ skipping 37 matching lines @@
   if (flags & PLATFORM_FILE_OPEN_TRUNCATED) {
     DCHECK(!open_flags);
     DCHECK(flags & PLATFORM_FILE_WRITE);
     open_flags = O_TRUNC;
   }
 
   if (!open_flags && !(flags & PLATFORM_FILE_OPEN) &&
       !(flags & PLATFORM_FILE_OPEN_ALWAYS)) {
     NOTREACHED();
     errno = EOPNOTSUPP;
-    *error_code = error_code ? PLATFORM_FILE_ERROR_FAILED : PLATFORM_FILE_OK;
+    if (error_code)
+      *error_code = *error_code ? PLATFORM_FILE_ERROR_FAILED :

[rvargas (doing something else), 2011/06/23 03:43:53]

I have no idea why this code was changed from what it was (r79058)... it looks
like an unintentional change.

This code should not be returning PLATFORM_FILE_OK when it fails on an
unreachable path. If this breaks something, the caller should be fixed.

[Greg Billock, 2011/06/23 16:58:32]

Yeah, I think the previous version was right. I'll copy jorlow on this change.

+          PLATFORM_FILE_OK;
     return kInvalidPlatformFileValue;
   }
 
   if (flags & PLATFORM_FILE_WRITE && flags & PLATFORM_FILE_READ) {
     open_flags |= O_RDWR;
   } else if (flags & PLATFORM_FILE_WRITE) {
     open_flags |= O_WRONLY;
   } else if (!(flags & PLATFORM_FILE_READ) &&
              !(flags & PLATFORM_FILE_WRITE_ATTRIBUTES) &&
              !(flags & PLATFORM_FILE_OPEN_ALWAYS)) {
@@ skipping 117 matching lines @@
   info->is_directory = S_ISDIR(file_info.st_mode);
   info->is_symbolic_link = S_ISLNK(file_info.st_mode);
   info->size = file_info.st_size;
   info->last_modified = base::Time::FromTimeT(file_info.st_mtime);
   info->last_accessed = base::Time::FromTimeT(file_info.st_atime);
   info->creation_time = base::Time::FromTimeT(file_info.st_ctime);
   return true;
 }
 
 }  // namespace base