Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 7222006: Add missing shortcuts to the keyboard overlay. (Closed)

Created:
9 years, 6 months ago by mazda
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add missing shortcuts to the keyboard overlay. This change adds the following shotcuts, which were missing. * Ctrl + Shift + Alt + / : View keyboard overlay * Shift + Alt + S : Focus status icon * Alt : Focus wrench menu * Shift + Alt + T : Focus toolbar * Shift + Alt + B : Focus bookmarks * Ctrl + Shift + / : Help * Ctrl + Shift + C : DOM Inspector * Ctrl + Shift + - : Zoom out * Ctrl + Shift + + : Zoom in BUG=chromium-os:16708 TEST=manually checked on chromebook Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/keyboard_overlay_data.js View 4 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mazda
9 years, 6 months ago (2011-06-21 12:49:40 UTC) #1
Daniel Erat
LGTM
9 years, 6 months ago (2011-06-21 16:08:06 UTC) #2
commit-bot: I haz the power
Try job failure for 7222006-1 on win for step "unit_tests". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=38514
9 years, 6 months ago (2011-06-22 02:29:24 UTC) #3
commit-bot: I haz the power
9 years, 6 months ago (2011-06-22 06:23:20 UTC) #4
Change committed as 89993

Powered by Google App Engine
This is Rietveld 408576698