Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome_frame/crash_server_init.h

Issue 7219007: Fix up crash reporting in unit tests and the Chrome Frame helper processes: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/crash_server_init.h
===================================================================
--- chrome_frame/crash_server_init.h (revision 88766)
+++ chrome_frame/crash_server_init.h (working copy)
@@ -21,6 +21,11 @@
extern const MINIDUMP_TYPE kLargerDumpType;
+enum CrashReportingFlags {
grt (UTC plus 2) 2011/06/22 14:15:01 I suggest CrashReportingMode. Rationale: "flags"
grt (UTC plus 2) 2011/06/22 14:15:01 Maybe add a comment here to explain what these mea
robertshield 2011/06/23 02:22:51 Done.
robertshield 2011/06/23 02:22:51 Done.
+ HEADLESS,
+ NORMAL
+};
+
// Returns a pointer to a static instance of a CustomClientInfo structure
// containing Chrome Frame specific data.
google_breakpad::CustomClientInfo* GetCustomInfo();
@@ -29,6 +34,6 @@
// constructed ExceptionHandler object. It is the responsibility of the caller
// to delete this object which will shut down the crash reporting machinery.
grt (UTC plus 2) 2011/06/22 14:15:01 Please document flags/mode.
robertshield 2011/06/23 02:22:51 Documented above.
google_breakpad::ExceptionHandler* InitializeCrashReporting(
- const wchar_t* cmd_line);
+ CrashReportingFlags flags);
#endif // CHROME_FRAME_CRASH_SERVER_INIT_H_

Powered by Google App Engine
This is Rietveld 408576698