Chromium Code Reviews| Index: chrome_frame/crash_server_init.h |
| =================================================================== |
| --- chrome_frame/crash_server_init.h (revision 88766) |
| +++ chrome_frame/crash_server_init.h (working copy) |
| @@ -21,6 +21,11 @@ |
| extern const MINIDUMP_TYPE kLargerDumpType; |
| +enum CrashReportingFlags { |
|
grt (UTC plus 2)
2011/06/22 14:15:01
I suggest CrashReportingMode. Rationale: "flags"
grt (UTC plus 2)
2011/06/22 14:15:01
Maybe add a comment here to explain what these mea
robertshield
2011/06/23 02:22:51
Done.
robertshield
2011/06/23 02:22:51
Done.
|
| + HEADLESS, |
| + NORMAL |
| +}; |
| + |
| // Returns a pointer to a static instance of a CustomClientInfo structure |
| // containing Chrome Frame specific data. |
| google_breakpad::CustomClientInfo* GetCustomInfo(); |
| @@ -29,6 +34,6 @@ |
| // constructed ExceptionHandler object. It is the responsibility of the caller |
| // to delete this object which will shut down the crash reporting machinery. |
|
grt (UTC plus 2)
2011/06/22 14:15:01
Please document flags/mode.
robertshield
2011/06/23 02:22:51
Documented above.
|
| google_breakpad::ExceptionHandler* InitializeCrashReporting( |
| - const wchar_t* cmd_line); |
| + CrashReportingFlags flags); |
| #endif // CHROME_FRAME_CRASH_SERVER_INIT_H_ |