Fix up crash reporting in unit tests and the Chrome Frame helper processes:

chrome_frame/crash_server_init.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

[grt (UTC plus 2), 2011/06/22 14:15:01]

2011

[robertshield, 2011/06/23 02:22:51]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_FRAME_CRASH_SERVER_INIT_H_
 #define CHROME_FRAME_CRASH_SERVER_INIT_H_
 
 #include "breakpad/src/client/windows/handler/exception_handler.h"
 
 // Possible names for Pipes:
 // Headless (testing) mode: "NamedPipe\ChromeCrashServices"
 // System-wide install: "NamedPipe\GoogleCrashServices\S-1-5-18"
 // Per-user install: "NamedPipe\GoogleCrashServices\<user SID>"
 extern const wchar_t kChromePipeName[];
 extern const wchar_t kGoogleUpdatePipeName[];
 extern const wchar_t kSystemPrincipalSid[];
 
 // Assume this implies headless mode and use kChromePipeName if it shows
 // up in the command line.
 extern const wchar_t kFullMemoryCrashReport[];

[grt (UTC plus 2), 2011/06/22 14:15:01]

This doesn't seem to be used anymore.  Remove it?

[robertshield, 2011/06/23 02:22:51]

Done.

 
 extern const MINIDUMP_TYPE kLargerDumpType;
 
+enum CrashReportingFlags {

[grt (UTC plus 2), 2011/06/22 14:15:01]

I suggest CrashReportingMode.  Rationale: "flags" implies bits in a bitfield,
and a singular type name makes more sense in the context of a function
declaration since only one member of the type is used at a time.

[grt (UTC plus 2), 2011/06/22 14:15:01]

Maybe add a comment here to explain what these mean?  Unless they're covered in
the comment for InitializeCrashReporting.

[robertshield, 2011/06/23 02:22:51]

Done.

[robertshield, 2011/06/23 02:22:51]

Done.

+  HEADLESS,
+  NORMAL
+};
+
 // Returns a pointer to a static instance of a CustomClientInfo structure
 // containing Chrome Frame specific data.
 google_breakpad::CustomClientInfo* GetCustomInfo();
 
 // Initializes breakpad crash reporting and returns a pointer to a newly
 // constructed ExceptionHandler object. It is the responsibility of the caller
 // to delete this object which will shut down the crash reporting machinery.

[grt (UTC plus 2), 2011/06/22 14:15:01]

Please document flags/mode.

[robertshield, 2011/06/23 02:22:51]

Documented above.

 google_breakpad::ExceptionHandler* InitializeCrashReporting(
-    const wchar_t* cmd_line);
+    CrashReportingFlags flags);
 
 #endif  // CHROME_FRAME_CRASH_SERVER_INIT_H_