Prevent a NULL deref

src/log.cc

Index: src/log.cc
===================================================================
--- src/log.cc	(revision 8294)
+++ src/log.cc	(working copy)
@@ -400,8 +400,10 @@
 
   void Remove(Address code_address) {
     HashMap::Entry* entry = FindEntry(code_address);
-    if (entry != NULL) DeleteArray(static_cast<const char*>(entry->value));
-    RemoveEntry(entry);
+    if (entry != NULL) {
+      DeleteArray(static_cast<const char*>(entry->value));

[mnaganov (inactive), 2011/06/22 05:02:47]

We allocate an array of char, why do we cast to const char* here?

[groby-ooo-7-16, 2011/06/22 17:17:26]

Presumably because DeleteArray takes a pointer to the first array element. That
seems to be that way since the beginning of time (or specifically, SVN r9 :)

[mnaganov (inactive), 2011/06/22 18:54:23]

I mean that a name string is allocated like this: NewArray<char>, that is, char*
And then it is casted to <const char*> here. Not a big deal, but still.

Do you have rights to land this?

+      RemoveEntry(entry);
+    }
   }
 
   void Move(Address from, Address to) {