Prevent a NULL deref

src/log.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 382 matching lines @@
     }
   }
 
   const char* Lookup(Address code_address) {
     HashMap::Entry* entry = FindEntry(code_address);
     return (entry != NULL) ? static_cast<const char*>(entry->value) : NULL;
   }
 
   void Remove(Address code_address) {
     HashMap::Entry* entry = FindEntry(code_address);
-    if (entry != NULL) DeleteArray(static_cast<const char*>(entry->value));
-    RemoveEntry(entry);
+    if (entry != NULL) {
+      DeleteArray(static_cast<const char*>(entry->value));

[mnaganov (inactive), 2011/06/22 05:02:47]

We allocate an array of char, why do we cast to const char* here?

[groby-ooo-7-16, 2011/06/22 17:17:26]

Presumably because DeleteArray takes a pointer to the first array element. That
seems to be that way since the beginning of time (or specifically, SVN r9 :)

[mnaganov (inactive), 2011/06/22 18:54:23]

I mean that a name string is allocated like this: NewArray<char>, that is, char*
And then it is casted to <const char*> here. Not a big deal, but still.

Do you have rights to land this?

+      RemoveEntry(entry);
+    }
   }
 
   void Move(Address from, Address to) {
     if (from == to) return;
     HashMap::Entry* from_entry = FindEntry(from);
     ASSERT(from_entry != NULL);
     void* value = from_entry->value;
     RemoveEntry(from_entry);
     HashMap::Entry* to_entry = FindOrCreateEntry(to);
     ASSERT(to_entry->value == NULL);
@@ skipping 1576 matching lines @@
 void SamplerRegistry::RemoveActiveSampler(Sampler* sampler) {
   ASSERT(sampler->IsActive());
   ScopedLock lock(mutex_);
   ASSERT(active_samplers_ != NULL);
   bool removed = active_samplers_->RemoveElement(sampler);
   ASSERT(removed);
   USE(removed);
 }
 
 } }  // namespace v8::internal