Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: views/ime/input_method_ibus.cc

Issue 7217008: Use input method to control visibility of virtual keyboard (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Update Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/ime/input_method_ibus.cc
diff --git a/views/ime/input_method_ibus.cc b/views/ime/input_method_ibus.cc
index 958e3dfdcfb0aa9c6e40d5cbfc4848e5507e886f..10cb7215945d04223222e10da34757945f8ff50d 100644
--- a/views/ime/input_method_ibus.cc
+++ b/views/ime/input_method_ibus.cc
@@ -369,6 +369,7 @@ void InputMethodIBus::DispatchKeyEvent(const KeyEvent& key) {
}
void InputMethodIBus::OnTextInputTypeChanged(View* view) {
+ InputMethodBase::OnTextInputTypeChanged(view);
if (context_ && IsViewFocused(view)) {
ResetContext();
UpdateContextFocusState();
@@ -413,7 +414,9 @@ base::i18n::TextDirection InputMethodIBus::GetInputTextDirection() {
}
bool InputMethodIBus::IsActive() {
- return context_ != NULL;
+ // We always need to receive TextInputTypeChanged signal,
+ // so just return true here.
bryeung 2011/06/22 01:56:02 This seems dangerous. Is there no way to ensure t
+ return true;
}
// static

Powered by Google App Engine
This is Rietveld 408576698