Use input method to control visibility of virtual keyboard

views/ime/input_method_ibus.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/ime/input_method_ibus.h"
 
 #include <ibus.h>
 
 #include <cstring>
 #include <set>
@@ skipping 351 matching lines @@
       ibus_keyval, ibus_keycode, ibus_state, -1, NULL,
       reinterpret_cast<GAsyncReadyCallback>(ProcessKeyEventDone),
       pending_key);
 
   // We don't want to suppress the result generated by this key event, but it
   // may cause problem. See comment in ResetContext() method.
   suppress_next_result_ = false;
 }
 
 void InputMethodIBus::OnTextInputTypeChanged(View* view) {
+  InputMethodBase::OnTextInputTypeChanged(view);
   if (context_ && IsViewFocused(view)) {
     ResetContext();
     UpdateContextFocusState();
   }
 }
 
 void InputMethodIBus::OnCaretBoundsChanged(View* view) {
   if (!context_focused_ || !IsViewFocused(view))
     return;
 
@@ skipping 24 matching lines @@
   // Not supported.
   return std::string("");
 }
 
 base::i18n::TextDirection InputMethodIBus::GetInputTextDirection() {
   // Not supported.
   return base::i18n::UNKNOWN_DIRECTION;
 }
 
 bool InputMethodIBus::IsActive() {
-  return context_ != NULL;
+  // We always need to receive TextInputTypeChanged signal,
+  // so just return true here.

[bryeung, 2011/06/22 01:56:02]

This seems dangerous.  Is there no way to ensure the propagation of the signal
without always saying we're active?

+  return true;
 }
 
 // static
 bool InputMethodIBus::IsInputMethodIBusEnabled() {
 #if defined(TOUCH_UI)
   return true;
 #else
   return inputmethod_ibus_enabled ||
       CommandLine::ForCurrentProcess()->HasSwitch(
           kEnableInputMethodIBusSwitch);
@@ skipping 560 matching lines @@
   DCHECK_EQ(GetIBus(), bus);
   DCHECK(data);
   IBusInputContext* ic =
       ibus_bus_create_input_context_async_finish(bus, res, NULL);
   if (ic)
     data->StoreOrAbandonInputContext(ic);
   delete data;
 }
 
 }  // namespace views