Issue 7216031: Coverity: Initialize member variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7216031: Coverity: Initialize member variables. (Closed)

Created:
9 years, 6 months ago by James Hawkins

Modified:
9 years, 6 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Coverity: Initialize member variables. CID=9269,13399,14520 BUG=none TEST=none R=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89966

Patch Set 3 : Remove trace_event.h changes. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
M	base/dir_reader_linux.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/process_util.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/text/text_elider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

LGTM with comments & nits http://codereview.chromium.org/7216031/diff/1/base/debug/trace_event.h File base/debug/trace_event.h (right): http://codereview.chromium.org/7216031/diff/1/base/debug/trace_event.h#newcode492 base/debug/trace_event.h:492: : p_data_(NULL) { nit: ...

9 years, 6 months ago (2011-06-21 22:34:44 UTC) #2

James Hawkins

9 years, 6 months ago (2011-06-21 22:45:05 UTC) #3

http://codereview.chromium.org/7216031/diff/1/base/debug/trace_event.h
File base/debug/trace_event.h (right):

http://codereview.chromium.org/7216031/diff/1/base/debug/trace_event.h#newcod...
base/debug/trace_event.h:492: : p_data_(NULL) {
On 2011/06/21 22:34:44, vandebo wrote:

Done.

http://codereview.chromium.org/7216031/diff/1/base/debug/trace_event.h#newcod...
base/debug/trace_event.h:507: // This Data struct workaround is to avoid
initializing all the members
On 2011/06/21 22:34:44, vandebo wrote:

I've pinged jbates about this.

Expand Messages | Collapse Messages

Issue 7216031: Coverity: Initialize member variables. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review fixes. #

Patch Set 3 : Remove trace_event.h changes. #

Messages