Coverity: Initialize member variables.

base/debug/trace_event.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Trace events are for tracking application performance.
 //
 // Events are issued against categories. Whereas LOG's
 // categories are statically defined, TRACE categories are created
 // implicitly with a string. For example:
 //   TRACE_EVENT_INSTANT0("MY_SUBSYSTEM", "SomeImportantEvent")
@@ skipping 470 matching lines @@
   std::vector<TraceEvent> logged_events_;
 
   DISALLOW_COPY_AND_ASSIGN(TraceLog);
 };
 
 namespace internal {
 
 // Used by TRACE_EVENTx macro. Do not use directly.
 class BASE_API TraceEndOnScopeClose {
  public:
-  TraceEndOnScopeClose() : p_data_(NULL) {}
+  TraceEndOnScopeClose()
+      : p_data_(NULL) {

[vandebo (ex-Chrome), 2011/06/21 22:34:44]

nit: IIRC this can stay on the previous line.

[James Hawkins, 2011/06/21 22:45:05]

On 2011/06/21 22:34:44, vandebo wrote:

Done.

+    memset(&data_, 0, sizeof(data));
+  }
   ~TraceEndOnScopeClose() {
     if (p_data_)
       AddEventIfEnabled();
   }
 
   void Initialize(const TraceCategory* category,
                   const char* name);
 
  private:
   // Add the end event if the category is still enabled.
   void AddEventIfEnabled();
 
   // This Data struct workaround is to avoid initializing all the members

[vandebo (ex-Chrome), 2011/06/21 22:34:44]

Is this comment saying we shouldn't add the memset above?

[James Hawkins, 2011/06/21 22:45:05]

On 2011/06/21 22:34:44, vandebo wrote:

I've pinged jbates about this.

   // in Data during construction of this object, since this object is always
   // constructed, even when tracing is disabled. If the members of Data were
   // members of this class instead, compiler warnings occur about potential
   // uninitialized accesses.
   struct Data {
     const TraceCategory* category;
     const char* name;
   };
   Data* p_data_;
   Data data_;
@@ skipping 33 matching lines @@
   Data* p_data_;
   Data data_;
 };
 
 }  // namespace internal
 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_TRACE_EVENT_H_