Issue 7215005: Unittest for webkit bug 62977 Web Inspector: [V8] Tab crashes in chromium after opening inspector on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7215005: Unittest for webkit bug 62977 Web Inspector: [V8] Tab crashes in chromium after opening inspector on (Closed)

Created:
9 years, 6 months ago by Dmitry Lomov (no reviews)

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, vsevik, rvargas (doing something else), yurys, pfeldman

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=62977 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89855

Patch Set 3 : Style nit fixed #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	chrome/browser/debugger/devtools_sanity_unittest.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM http://codereview.chromium.org/7215005/diff/2001/chrome/browser/debugger/devtools_sanity_unittest.cc File chrome/browser/debugger/devtools_sanity_unittest.cc (right): http://codereview.chromium.org/7215005/diff/2001/chrome/browser/debugger/devtools_sanity_unittest.cc#newcode319 chrome/browser/debugger/devtools_sanity_unittest.cc:319: ui_test_utils::ExecuteJavaScriptAndExtractString( style nit: wrong alignment

9 years, 6 months ago (2011-06-21 09:48:16 UTC) #1

rvargas (doing something else)

9 years, 6 months ago (2011-06-21 18:53:24 UTC) #4

FYI, this cl was commited without a proper description.

Expand Messages | Collapse Messages

Issue 7215005: Unittest for webkit bug 62977 Web Inspector: [V8] Tab crashes in chromium after opening inspector on (Closed)

Description

Patch Set 1 #

Patch Set 2 : Typo fixed #

Patch Set 3 : Style nit fixed #

Messages