Part I of many. Moving FileIO, FileRef, and FileSystem out of Dev. For now, just copying over s...

Part I of many.  Moving FileIO, FileRef, and FileSystem out of Dev.  For now, just copying over so the Dev and non-Dev versions live side by side.  Purposely left out the new files out of ppapi/tests/all_c_includes.h and ppapi/tests/all_cpp_includes.h until the changes are pushed down to the NaCl toolchain, at which point the dependencies can point to the non-Dev files.

[nfullagar, 2011-06-21 20:15:23]

couple of nits

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_io.h
File ppapi/c/ppb_file_io.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_io.h#newcode42
ppapi/c/ppb_file_io.h:42: #define PPB_FILEIO_INTERFACE_1_0 "PPB_FileIO;1.0"
When previous interfaces came out of Dev, it was recommended to keep the
interface < 1.0 at first.

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_ref.h
File ppapi/c/ppb_file_ref.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_ref.h#newco...
ppapi/c/ppb_file_ref.h:16: #define PPB_FILEREF_INTERFACE_1_0 "PPB_FileRef;1.0"
See previous comment about interface # < 1.0

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_system.h
File ppapi/c/ppb_file_system.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_system.h#ne...
ppapi/c/ppb_file_system.h:17: #define PPB_FILESYSTEM_INTERFACE_1_0
"PPB_FileSystem;1.0"
Please see previous comment re interface number

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/trusted/ppb_file_io_...
File ppapi/c/trusted/ppb_file_io_trusted.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/trusted/ppb_file_io_...
ppapi/c/trusted/ppb_file_io_trusted.h:1: /* Copyright (c) 2010 The Chromium
Authors. All rights reserved.
2011

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/trusted/ppb_file_io_...
ppapi/c/trusted/ppb_file_io_trusted.h:13: #define
PPB_FILEIOTRUSTED_INTERFACE_1_0 "PPB_FileIOTrusted(Dev);1.0"
Please see earlier comment on interface #

http://codereview.chromium.org/7210027/diff/8001/ppapi/cpp/file_system.h
File ppapi/cpp/file_system.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/cpp/file_system.h#newc...
ppapi/cpp/file_system.h:1: // Copyright (c) 2010 The Chromium Authors. All
rights reserved.
2011

http://codereview.chromium.org/7210027/diff/8001/ppapi/ppapi_cpp.gypi
File ppapi/ppapi_cpp.gypi (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/ppapi_cpp.gypi#newcode1
ppapi/ppapi_cpp.gypi:1: # Copyright (c) 2010 The Chromium Authors. All rights
reserved.
2011

[Sang Ahn, 2011-06-21 20:41:08]

PTAL

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_io.h
File ppapi/c/ppb_file_io.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_io.h#newcode42
ppapi/c/ppb_file_io.h:42: #define PPB_FILEIO_INTERFACE_1_0 "PPB_FileIO;1.0"
On 2011/06/21 20:15:23, nfullagar wrote:
> When previous interfaces came out of Dev, it was recommended to keep the
> interface < 1.0 at first.

Done.

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_ref.h
File ppapi/c/ppb_file_ref.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_ref.h#newco...
ppapi/c/ppb_file_ref.h:16: #define PPB_FILEREF_INTERFACE_1_0 "PPB_FileRef;1.0"
On 2011/06/21 20:15:23, nfullagar wrote:
> See previous comment about interface # < 1.0

Done.

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_system.h
File ppapi/c/ppb_file_system.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/ppb_file_system.h#ne...
ppapi/c/ppb_file_system.h:17: #define PPB_FILESYSTEM_INTERFACE_1_0
"PPB_FileSystem;1.0"
On 2011/06/21 20:15:23, nfullagar wrote:
> Please see previous comment re interface number

Done.

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/trusted/ppb_file_io_...
File ppapi/c/trusted/ppb_file_io_trusted.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/trusted/ppb_file_io_...
ppapi/c/trusted/ppb_file_io_trusted.h:1: /* Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/06/21 20:15:23, nfullagar wrote:
> 2011

Done.

http://codereview.chromium.org/7210027/diff/8001/ppapi/c/trusted/ppb_file_io_...
ppapi/c/trusted/ppb_file_io_trusted.h:13: #define
PPB_FILEIOTRUSTED_INTERFACE_1_0 "PPB_FileIOTrusted(Dev);1.0"
On 2011/06/21 20:15:23, nfullagar wrote:
> Please see earlier comment on interface #

Done.

http://codereview.chromium.org/7210027/diff/8001/ppapi/cpp/file_system.h
File ppapi/cpp/file_system.h (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/cpp/file_system.h#newc...
ppapi/cpp/file_system.h:1: // Copyright (c) 2010 The Chromium Authors. All
rights reserved.
On 2011/06/21 20:15:23, nfullagar wrote:
> 2011

Done.

http://codereview.chromium.org/7210027/diff/8001/ppapi/ppapi_cpp.gypi
File ppapi/ppapi_cpp.gypi (right):

http://codereview.chromium.org/7210027/diff/8001/ppapi/ppapi_cpp.gypi#newcode1
ppapi/ppapi_cpp.gypi:1: # Copyright (c) 2010 The Chromium Authors. All rights
reserved.
On 2011/06/21 20:15:23, nfullagar wrote:
> 2011

Done.

[nfullagar, 2011-06-21 20:55:46]

lgtm if gcl try is green.

[Sang Ahn, 2011-06-21 23:24:15]

The try servers are green.  Since I am not a chromium contributor yet, could
you check in this patch for me?

On Tue, Jun 21, 2011 at 2:55 PM, <nfullagar@google.com> wrote:

> lgtm if gcl try is green.
>
>
>
http://codereview.chromium.**org/7210027/<http://codereview.chromium.org/7210...
>



-- 
Sang Wook Ahn

[Sang Ahn, 2011-06-22 21:19:45]

It looks like the commit check box brettw mentioned is not available to me
since I don't have the permission.  I've ask mal to add me as a committer,
and I told him you were sponsoring me as committer.  In the mean time, could
you check in this patch for me so we can get these changes pushed through to
the toolchain?

On Tue, Jun 21, 2011 at 2:55 PM, <nfullagar@google.com> wrote:

> lgtm if gcl try is green.
>
>
>
http://codereview.chromium.**org/7210027/<http://codereview.chromium.org/7210...
>



-- 
Sang Wook Ahn

[nfullagar, 2011-06-22 23:29:53]

http://codereview.chromium.org/7242002

On Wed, Jun 22, 2011 at 2:19 PM, Sang Ahn <sanga@google.com> wrote:

> It looks like the commit check box brettw mentioned is not available to me
> since I don't have the permission.  I've ask mal to add me as a committer,
> and I told him you were sponsoring me as committer.  In the mean time, could
> you check in this patch for me so we can get these changes pushed through to
> the toolchain?
>
> On Tue, Jun 21, 2011 at 2:55 PM, <nfullagar@google.com> wrote:
>
>> lgtm if gcl try is green.
>>
>>
>>
http://codereview.chromium.**org/7210027/<http://codereview.chromium.org/7210...
>>
>
>
>
> --
> Sang Wook Ahn
>
>
>