Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 7242002: Sang's initial CL for moving the file interface out of dev. (Closed)

Created:
9 years, 6 months ago by nfullagar
Modified:
9 years, 6 months ago
Reviewers:
brettw, Sang Ahn
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Sang's initial CL for moving the file interface out of dev. (see http://codereview.chromium.org/7210027/ for Sang's original CL) Part I of many. Moving FileIO, FileRef, and FileSystem out of Dev. For now, just copying over so the Dev and non-Dev versions live side by side. Purposely left out the new files out of ppapi/tests/all_c_includes.h and ppapi/tests/all_cpp_includes.h until the changes are pushed down to the NaCl toolchain, at which point the dependencies can point to the non-Dev files.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+756 lines, -1 line) Patch
A ppapi/c/pp_file_info.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ppapi/c/ppb_file_io.h View 1 chunk +119 lines, -0 lines 0 comments Download
A ppapi/c/ppb_file_ref.h View 1 chunk +81 lines, -0 lines 0 comments Download
A ppapi/c/ppb_file_system.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ppapi/c/trusted/ppb_file_io_trusted.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ppapi/cpp/file_io.h View 1 chunk +52 lines, -0 lines 0 comments Download
A ppapi/cpp/file_io.cc View 1 chunk +110 lines, -0 lines 1 comment Download
A ppapi/cpp/file_ref.h View 1 chunk +66 lines, -0 lines 0 comments Download
A ppapi/cpp/file_ref.cc View 1 chunk +114 lines, -0 lines 1 comment Download
A ppapi/cpp/file_system.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ppapi/cpp/file_system.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 4 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nfullagar
9 years, 6 months ago (2011-06-22 22:46:01 UTC) #1
Sang Ahn
A few nits. http://codereview.chromium.org/7242002/diff/1/ppapi/cpp/file_io.cc File ppapi/cpp/file_io.cc (right): http://codereview.chromium.org/7242002/diff/1/ppapi/cpp/file_io.cc#newcode42 ppapi/cpp/file_io.cc:42: const CompletionCallback& cc) { Funny indent. ...
9 years, 6 months ago (2011-06-22 23:34:25 UTC) #2
brettw
Did you do svn mv for the files before modifying them? Did that get lost ...
9 years, 6 months ago (2011-06-22 23:40:16 UTC) #3
Sang Ahn
fwiw, here's <http://codereview.chromium.org/7210027/> the original CL On Wed, Jun 22, 2011 at 5:40 PM, <brettw@chromium.org> ...
9 years, 6 months ago (2011-06-22 23:55:44 UTC) #4
nfullagar
9 years, 6 months ago (2011-06-23 01:12:47 UTC) #5
Good catch, I'm abandoning this CL and starting over w/ svn copy.

On Wed, Jun 22, 2011 at 4:40 PM, <brettw@chromium.org> wrote:

> Did you do svn mv for the files before modifying them? Did that get lost
> when
> you took over Sang's change? It would be nice to preserve the history.
>
>
>
http://codereview.chromium.**org/7242002/<http://codereview.chromium.org/7242...
>

Powered by Google App Engine
This is Rietveld 408576698