AppCaches which belong to hosted apps are not protected from deletion

webkit/appcache/appcache_service.h

Index: webkit/appcache/appcache_service.h
diff --git a/webkit/appcache/appcache_service.h b/webkit/appcache/appcache_service.h
index 4952c941270c17ab87b63d78ae5d273c53652229..7a07e825c82b35023b42838948b77b7b30fc8471 100644
--- a/webkit/appcache/appcache_service.h
+++ b/webkit/appcache/appcache_service.h
@@ -73,23 +73,28 @@ class AppCacheService {
   // Populates 'collection' with info about all of the appcaches stored
   // within the service, 'callback' is invoked upon completion. The service
   // acquires a reference to the 'collection' until until completion.
-  // This method always completes asynchronously.
-  void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
-                          net::CompletionCallback* callback);
-
-  // Deletes the group identified by 'manifest_url', 'callback' is
-  // invoked upon completion. Upon completion, the cache group and
-  // any resources within the group are no longer loadable and all
-  // subresource loads for pages associated with a deleted group
-  // will fail. This method always completes asynchronously.
-  void DeleteAppCacheGroup(const GURL& manifest_url,
+  // This method always completes asynchronously. (virtual for unittesting)
+  virtual void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
+                                  net::CompletionCallback* callback);
+  // The same as GetAllAppCacheInfo but completes synchronously. (virtual for
+  // unittesting)
+  virtual void SyncGetAllAppCacheInfo(AppCacheInfoCollection* collection);

[michaeln, 2011/07/14 00:42:34]

Please remove the Sync prefixed methods from this class.

[marja(google), 2011/07/14 10:31:59]

Done.

+
+  // Deletes the group identified by 'manifest_url', 'callback' is invoked upon
+  // completion. Upon completion, the cache group and any resources within the
+  // group are no longer loadable and all subresource loads for pages associated
+  // with a deleted group will fail. This method always completes
+  // asynchronously. (virtual for unittesting)
+  virtual void DeleteAppCacheGroup(const GURL& manifest_url,
                            net::CompletionCallback* callback);
+  // The same as DeleteAppCacheGroup but completes synchronously. (virtual for
+  // unittesting)
+  virtual void SyncDeleteAppCacheGroup(const GURL& manifest_url);
 
   // Deletes all appcaches for the origin, 'callback' is invoked upon
   // completion. This method always completes asynchronously.
-  // (virtual for unittesting)
-  virtual void DeleteAppCachesForOrigin(const GURL& origin,
-                                        net::CompletionCallback* callback);
+  void DeleteAppCachesForOrigin(const GURL& origin,
+                                net::CompletionCallback* callback);
 
   // Context for use during cache updates, should only be accessed
   // on the IO thread. We do NOT add a reference to the request context,