AppCaches which belong to hosted apps are not protected from deletion

webkit/appcache/appcache_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
 #define WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
 
 #include <map>
 #include <set>
 
@@ skipping 55 matching lines @@
   }
 
   // Determines if a request for 'url' can be satisfied while offline.
   // This method always completes asynchronously.
   void CanHandleMainResourceOffline(const GURL& url,
                                     net::CompletionCallback* callback);
 
   // Populates 'collection' with info about all of the appcaches stored
   // within the service, 'callback' is invoked upon completion. The service
   // acquires a reference to the 'collection' until until completion.
-  // This method always completes asynchronously.
-  void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
-                          net::CompletionCallback* callback);
+  // This method always completes asynchronously. (virtual for unittesting)
+  virtual void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
+                                  net::CompletionCallback* callback);
+  // The same as GetAllAppCacheInfo but completes synchronously. (virtual for
+  // unittesting)
+  virtual void SyncGetAllAppCacheInfo(AppCacheInfoCollection* collection);

[michaeln, 2011/07/14 00:42:34]

Please remove the Sync prefixed methods from this class.

[marja(google), 2011/07/14 10:31:59]

Done.

 
-  // Deletes the group identified by 'manifest_url', 'callback' is
-  // invoked upon completion. Upon completion, the cache group and
-  // any resources within the group are no longer loadable and all
-  // subresource loads for pages associated with a deleted group
-  // will fail. This method always completes asynchronously.
-  void DeleteAppCacheGroup(const GURL& manifest_url,
+  // Deletes the group identified by 'manifest_url', 'callback' is invoked upon
+  // completion. Upon completion, the cache group and any resources within the
+  // group are no longer loadable and all subresource loads for pages associated
+  // with a deleted group will fail. This method always completes
+  // asynchronously. (virtual for unittesting)
+  virtual void DeleteAppCacheGroup(const GURL& manifest_url,
                            net::CompletionCallback* callback);
+  // The same as DeleteAppCacheGroup but completes synchronously. (virtual for
+  // unittesting)
+  virtual void SyncDeleteAppCacheGroup(const GURL& manifest_url);
 
   // Deletes all appcaches for the origin, 'callback' is invoked upon
   // completion. This method always completes asynchronously.
-  // (virtual for unittesting)
-  virtual void DeleteAppCachesForOrigin(const GURL& origin,
-                                        net::CompletionCallback* callback);
+  void DeleteAppCachesForOrigin(const GURL& origin,
+                                net::CompletionCallback* callback);
 
   // Context for use during cache updates, should only be accessed
   // on the IO thread. We do NOT add a reference to the request context,
   // it is the callers responsibility to ensure that the pointer
   // remains valid while set.
   net::URLRequestContext* request_context() const { return request_context_; }
   void set_request_context(net::URLRequestContext* context) {
     request_context_ = context;
   }
 
@@ skipping 51 matching lines @@
   BackendMap backends_;  // One 'backend' per child process.
   // Context for use during cache updates.
   net::URLRequestContext* request_context_;
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheService);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_SERVICE_H_