Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 7205042: pnacl: move libgcc compiler flags into utman (Closed)

Created:
9 years, 6 months ago by robertm
Modified:
9 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Move libgcc compiler flags into utman so we can experiment with a bitcode only version. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1520

Patch Set 1 #

Total comments: 4

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M compiler-rt/lib/Makefile-pnacl View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertm
PTAL
9 years, 6 months ago (2011-06-20 21:06:24 UTC) #1
jvoung - send to chromium...
http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl File compiler-rt/lib/Makefile-pnacl (right): http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl#newcode10 compiler-rt/lib/Makefile-pnacl:10: # ARCH ARCH no longer needed?
9 years, 6 months ago (2011-06-20 21:10:01 UTC) #2
robertm
PTAL http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl File compiler-rt/lib/Makefile-pnacl (right): http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl#newcode10 compiler-rt/lib/Makefile-pnacl:10: # ARCH On 2011/06/20 21:10:02, jvoung wrote: > ...
9 years, 6 months ago (2011-06-20 21:16:06 UTC) #3
robertm
Sorry, this has moved to the utman script On 2011/06/20 21:16:06, robertm wrote: > PTAL ...
9 years, 6 months ago (2011-06-20 21:16:42 UTC) #4
jvoung - send to chromium...
LGTM http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl File compiler-rt/lib/Makefile-pnacl (right): http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl#newcode10 compiler-rt/lib/Makefile-pnacl:10: # ARCH On 2011/06/20 21:16:06, robertm wrote: > ...
9 years, 6 months ago (2011-06-20 23:06:41 UTC) #5
robertm
9 years, 6 months ago (2011-06-20 23:17:14 UTC) #6
http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl
File compiler-rt/lib/Makefile-pnacl (right):

http://codereview.chromium.org/7205042/diff/1/compiler-rt/lib/Makefile-pnacl#...
compiler-rt/lib/Makefile-pnacl:10: # ARCH
will clean this up before submitting

On 2011/06/20 23:06:41, jvoung wrote:
> On 2011/06/20 21:16:06, robertm wrote:
> > On 2011/06/20 21:10:02, jvoung wrote:
> > > ARCH no longer needed?
> > 
> > just fixed that - it will eventually be obsolete
> 
> So, what is the outcome? Cleanup now, or no?

Powered by Google App Engine
This is Rietveld 408576698