Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 7204023: Revert 89489 - net: don't check revocation when fetching PAC files. (Closed)

Created:
9 years, 6 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 89489 - net: don't check revocation when fetching PAC files. If a PAC file is configured on an HTTPS URL we get into trouble. In order to check revocation we need to make an HTTP request to the OCSP/CRL server, which needs the PAC script to load and so we deadlock. With this change we don't check revocation for PAC fetches. BUG=86219 TEST=Configure a PAC script on HTTPS. Review URL: http://codereview.chromium.org/7170026 TBR=agl@chromium.org NOTE: I'll roll this back in if it turns out unrelated to the ProxyEvents failure. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -39 lines) Patch
M net/base/load_flags_list.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 5 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Chris Evans
9 years, 6 months ago (2011-06-19 20:06:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698