net: don't check revocation when fetching PAC files.

net: don't check revocation when fetching PAC files.

If a PAC file is configured on an HTTPS URL we get into trouble. In order to
check revocation we need to make an HTTP request to the OCSP/CRL server, which
needs the PAC script to load and so we deadlock.

With this change we don't check revocation for PAC fetches.

BUG=86219
TEST=Configure a PAC script on HTTPS.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89489

[wtc, 2011-06-16 18:47:15]

LGTM.

eroman: could you review this CL, in particular
net/proxy/proxy_script_fetcher_impl_unittest.cc ?

agl: please wait for eroman's review of the unit test, as
I didn't review it.

http://codereview.chromium.org/7170026/diff/1/net/base/load_flags_list.h
File net/base/load_flags_list.h (right):

http://codereview.chromium.org/7170026/diff/1/net/base/load_flags_list.h#newc...
net/base/load_flags_list.h:56: LOAD_FLAG(NO_CERT_REVOCATION_CHECKING, 1 << 11)
Nit: please change NO_ to DISABLE_ or BYPASS_.

http://codereview.chromium.org/7170026/diff/1/net/http/http_network_transacti...
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/7170026/diff/1/net/http/http_network_transacti...
net/http/http_network_transaction.cc:163: start_time_ = base::Time::Now();
It may be better to check request_->load_flags and set
ssl_config_.rev_checking_enabled to false here, as soon
as we have received request_ on line 162 above.

[eroman, 2011-06-16 19:06:34]

lgtm.

another way to solve this is to put the "don't check revocation" dependency into
the URLRequestContext. PAC fetching uses its own request context (to similarly
remove circular dependency on proxy to fetch proxy script).

See ConstructProxyScriptFetcherContext() in io_thread.cc.

[agl, 2011-06-17 14:47:29]

http://codereview.chromium.org/7170026/diff/1/net/base/load_flags_list.h
File net/base/load_flags_list.h (right):

http://codereview.chromium.org/7170026/diff/1/net/base/load_flags_list.h#newc...
net/base/load_flags_list.h:56: LOAD_FLAG(NO_CERT_REVOCATION_CHECKING, 1 << 11)
On 2011/06/16 18:47:15, wtc wrote:
> Nit: please change NO_ to DISABLE_ or BYPASS_.

Done.

http://codereview.chromium.org/7170026/diff/1/net/http/http_network_transacti...
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/7170026/diff/1/net/http/http_network_transacti...
net/http/http_network_transaction.cc:163: start_time_ = base::Time::Now();
On 2011/06/16 18:47:15, wtc wrote:
> It may be better to check request_->load_flags and set
> ssl_config_.rev_checking_enabled to false here, as soon
> as we have received request_ on line 162 above.

Done.

[commit-bot: I haz the power, 2011-06-17 15:46:22]

Change committed as 89489