Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: content/common/gpu/gpu_channel.cc

Issue 7200033: Fix crashes when loading gles2.cc on browser startup, and during playback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_channel.cc
diff --git a/content/common/gpu/gpu_channel.cc b/content/common/gpu/gpu_channel.cc
index 003160203f2713c604d2e0f15f3f85771de83613..595e8dd16dc3c00e4f68dc11c1940630998820f6 100644
--- a/content/common/gpu/gpu_channel.cc
+++ b/content/common/gpu/gpu_channel.cc
@@ -212,7 +212,7 @@ bool GpuChannel::OnControlMessageReceived(const IPC::Message& msg) {
OnAssignTexturesToVideoDecoder)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
- DCHECK(handled);
+ DCHECK(handled) << msg.type();
return handled;
}
@@ -325,6 +325,12 @@ void GpuChannel::OnCreateVideoDecoder(int32 decoder_host_id,
int32 decoder_id = GenerateRouteID();
+ // TODO(fischman): this is a BUG. We hand off stub->scheduler()->decoder()
+ // to be baked into the resulting GpuVideoDecodeAccelerator, but we don't own
+ // that GVDA, and we make no attempt to tear it down if/when
+ // stub->scheduler()->decoder() is destroyed. GpuVideoService should be
+ // subsumed into this class and GpuVideoDecodeAccelerator should be owned by
+ // the GpuCommandBufferStub that owns the commandbuffer GVDA is using.
bool ret = service->CreateVideoDecoder(
this, &router_, decoder_host_id, decoder_id, stub->scheduler()->decoder(),
configs);
« no previous file with comments | « no previous file | content/common/gpu/media/gles2_texture_to_egl_image_translator.cc » ('j') | ppapi/examples/gles2/gles2.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698